Project panel from lexicographical to natural sorting.

[TomPlanche]

While working on Leetcode problems, I stumbled upon a project panel sorting who bothered me.
The folders (and files) are lexicographicaly sorted...

This is annoying and not natural.

I found that the responsible for this is sort_worktree_entries in the crates/project/src/project.rs file used in the line 2005 project::sort_worktree_entries(&mut visible_worktree_entries); of the ./project_panel/src/project_panel.rs file.
This uses the ./crates/util/src/paths.rs's compare_paths function.

I'm changing the compare_paths function to compare_paths_with_sort_mode.

Now the folders and files are in alphabetical order.

[SomeoneToIgnore]

You're definitely not supposed to change things forever, but simply replacing the sorting mechanism: someone prefers things the other way around.

What's really needed is multiple sorting modes and a way to toggle between them.

[SomeoneToIgnore]

So, looks like ProjectPanelSettings is the wrong place to put this into?
Sounds odd indeed, as we're supposed to sort things in the outline panel at least, same way as in the project panel?
Seems that you want it in the file_finder's open_path_prompt.rs which is, again, not the ProjectPanel.

• ProjectSettings could be a better place?
• We might reconsider "sort everything similarly" restriction from my previous write-ups, as things have mutated a bit since the last time: open_path_prompt.rs might want a different sorting? Not sure but worth checking, see workspace::Open: Add trailing / to directories on completion #25045 for more details.

[TomPlanche]

ProjectSettings looks good, made the changes, does it look good to you ?

[TomPlanche]

We have a dedicated file_sorting key that for now only takes a strategy field.
We could add new strategies, dedicated strategies per panel, etc.

I thought about adding a file_before_folders boolean, a hidden_file_first boolean, uppercase_before_lowercase for greater personalization.

[SomeoneToIgnore]

That can also go as a separate setting to each panel, in theory, but this all are details, seems that you're over your main issues and ready to submit a PR?

[TomPlanche]

PR live at #25148 :)

[jnptk]

What's the status here? Really looking forward for this feature!

[TomPlanche]

The choice varies between making alphabetical sorting the default value or making it a parameter.
#25148.