Status bar diagnostic button doesn't close open diagnostics tab.

[Angelk90]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

Registrazione.schermo.2024-06-11.alle.14.15.22.mov

Environment

Zed: v0.139.3 (Zed Preview)
OS: macOS 14.1.1
Memory: 16 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

[JosephTLyons]

This is expected, since the diagnostics multi-buffer is just a tab, it is treated mostly the same as any other. The diagnostics tab can be opened in multiple panes if you want (split), so right now, that button is just an open-only button.

[Angelk90]

@JosephTLyons :
Why not put it here then?

If I see that button I expect it can both open and close it.

How does terminal panel.

[notpeter]

@iamnbutler Do you have any thoughts on this? Every other icon in our status bar, if you click on it once it shows the panel and if you click on it again it hides. Is this something that could fixed this Quality week or is it operating as designed?

[Angelk90]

@notpeter : Does it work for you? If you click when it's open, does it close?

[notpeter]

No. Clicking on the icon does not hide/close for me.
This behavior deviates from all the other status bar icons.

[iamnbutler]

We know it works this way – the issue is diagnostics is not singular. Multiple can be open, and clicking the icon focuses any non-foregrounded diagnostic tab.

Essentially this would require changing the way diagnostics works to make it singular.

I'm not sure if that is a change we would be willing to make.