windows: Allow canceling prompt with escape #22821
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
|
It seems that currently, on the main branch, the prompt window can be closed using the And the description of "Indicates that the dialog should be able to be closed using Alt-F4, Escape, and the title bar's close button even if no cancel button is specified in either the dwCommonButtons or pButtons members." Does this match our situation? |
|
when you delete file in project_panel, you cannot using |
This comment was marked as resolved.
This comment was marked as resolved.
|
Hi @CharlesChen0823 , thanks for reporting and fixing this. And I found that the issue here is more complex than we thought, I opened a new PR for this #25391 |
JunkuiZhang
added a commit
that referenced
this pull request
Feb 22, 2025
Closes #22821 It turns out that on Windows, the `Cancel` button should **always** have a button ID of `2`. Even if the button label is something like "Don't Cancel", when the user presses the `Esc` key, Windows will still report that the button with ID `2` was pressed. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: TDF_ALLOW_DIALOG_CANCELLATION
enable escape for cancle prompt dialog
Release Notes: