Regression on task_name when spawning task with spaces in name from keybinding

[danieljimenez-mycase]

Summary

Setting task_name with spaces does not work with keybindings

1.add task to task.json

{
  "label": "start lazygit",
  "command": "lazygit -p $ZED_WORKTREE_ROOT"
}

add keybinding

{
  "context": "Workspace",
  "bindings": {
    "alt-g": [
      "task::Spawn",
      { "task_name": "start lazygit", "reveal_target": "center" }
    ]
  }
}

3. use keybinding

Actual Behavior:
opens task selector

Expected Behavior:
opens task with that name

I fixed this by using "_" instead of spaces. I got this idea because the auto config update changed it to be that.
Do we need to update the docs instead?

Zed Version and System Specs

Zed: v0.173.8 (Zed)
OS: macOS 14.7.4
Memory: 16 GiB
Architecture: aarch64

[497e0bdf29873]

As documented in #24833, also dashes seem to be unallowed. The auto-update should tell what changes it made, and such task name restrictions documented.

[injust]

I also can't use any uppercase letters in the task name, and as a result variables don't work either (e.g. $ZED_STEM).

[maxbrunsfeld]

@osiewicz Do you know of any changes recently that could have caused a regression with task names containing spaces?

[osiewicz]

Not that I'm aware of. I spun up a quick debug session and it seems that the action disposition itself has a task name with spaces replaced? I'm not sure what's up with that.
E.g. the following key binding:

      "shift-f": [
        "task::Spawn",
        { "task_name": "a b" }
      ]

Deserializes as:

[crates/tasks_ui/src/tasks_ui.rs:96:5] &action = ByName {
    task_name: "a_b",
    reveal_target: None,
}

which is obviously wrong and seems to be the culprit of a problem.

[0xtimsb]

I think I know why this is happening. Seems related to in-memory migrator turning binding values to snake case. Picking this up.

[osiewicz]

Yep, the settings load just fine for me when I disable the keymap migration.

[maxbrunsfeld]

@danieljimenez-mycase @497e0bdf29873 Thanks for the report; we'll need to publish a patch release for this. We'll let you know when it is out.

[dazsmith]

After a recent update (I guess this one), when I opened my keymap.json file, zed automatically notified me that the file needed to be updated to a new format. I accepted without further thought. It turns out that the task_names had spaces replaced by underscores, eg. pdflatex build $\mapsto$ pdflatex_build. Fine, but the same thing was not done automatically in the tasks.json file. More seriously, because I had not read this issue, it took me a long time to understand why my keymaps were causing the tasks modal to appear instead of just running the tasks as they used to.