Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings are not case-insensitive and don't give warnings #25353

Open
nickav opened this issue Feb 21, 2025 · 1 comment
Open

Keybindings are not case-insensitive and don't give warnings #25353

nickav opened this issue Feb 21, 2025 · 1 comment
Labels
keymap / key binding Feedback for keyboard shortcuts, key mapping, etc reproducible Verified steps to reproduce included

Comments

@nickav
Copy link

nickav commented Feb 21, 2025

Summary

I tried to make a keybinding for F5, but it wasn't working and I couldn't figure out why.

Steps to trigger the problem:

// File: keymap.json
[
  {
    "bindings": {
      "F5": ["task::Spawn", { "task_name": "Build" }],
    }
  },
]

Actual Behavior:

When I press F5 nothing happens and I don't get a yellow squiggle warning under the keymap.

Expected Behavior:

Either:

  1. Allow keybindings to be case-insensitive or
  2. Show a yellow squiggle indicating that this keybinding is invalid

Zed Version and System Specs

Zed: v0.174.6 (Zed)
OS: macOS 13.5.0
Memory: 16 GiB
Architecture: aarch64

@beniaminzagan beniaminzagan added keymap / key binding Feedback for keyboard shortcuts, key mapping, etc reproducible Verified steps to reproduce included labels Feb 21, 2025
@beniaminzagan
Copy link
Contributor

beniaminzagan commented Feb 21, 2025

Thank you for the repport! I was able to reproduce this in Zed Preview 175.3. I wouldn't make it case-insensitive when it comes to keybindings but for the f-keys we should maybe allow to write it with a capital F, I don't think we can do anything wrong with this - or give a warning when a capital is used and how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keymap / key binding Feedback for keyboard shortcuts, key mapping, etc reproducible Verified steps to reproduce included
Projects
None yet
Development

No branches or pull requests

2 participants