Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zed --wait does not exit when closing the entire Zed window #5264

Closed
1 task done
maxbrunsfeld opened this issue Jul 28, 2022 · 2 comments
Closed
1 task done

zed --wait does not exit when closing the entire Zed window #5264

maxbrunsfeld opened this issue Jul 28, 2022 · 2 comments
Labels
bug [core label] cli Command-line interface feedback

Comments

@maxbrunsfeld
Copy link
Collaborator

Check for existing issues

  • Completed

Describe the bug

The --wait flag lets you use the Zed CLI as an EDITOR for things like commit messages. The zed CLI process will run until the given files have been closed. But right now, if I close a file by closing its entire Zed window, the zed CLI process will fail to exit.

To reproduce

  1. Run zed --wait some/file
  2. Close the resulting Zed window with cmd-shift-w
  3. 💥 See that the zed --wait command is still running

Expected behavior

The command should exit when closing the window, because the file is no longer open.

Environment

Zed 0.49.1 – /Applications/Zed.app
macOS 12.4
architecture arm64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue

No response

@maxbrunsfeld maxbrunsfeld added bug [core label] triage labels Jul 28, 2022
@JosephTLyons JosephTLyons added cli Command-line interface feedback and removed triage labels Jul 30, 2022
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
Copy link

Hi there! 👋
We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. Are you able to reproduce this issue in the latest version of Zed? If so, please let us know by commenting on this issue and we will keep it open; otherwise, we'll close it in a week. Feel free to open a new issue if you're seeing this message after the issue has been closed.
Thanks for your help!

@github-actions github-actions bot added the stale Label used by `stale` action label Sep 23, 2024
@notpeter
Copy link
Member

I think this is fixed. I used zed as my git commit editor and have not run into this.

A related enhancement:

@notpeter notpeter removed the stale Label used by `stale` action label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] cli Command-line interface feedback
Projects
None yet
Development

No branches or pull requests

3 participants