Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(Config): Check XDG Config Directory on Mac #291

Closed
ocboogie opened this issue Apr 20, 2021 · 3 comments
Closed

Feature(Config): Check XDG Config Directory on Mac #291

ocboogie opened this issue Apr 20, 2021 · 3 comments
Labels
config Improvements to the configuration system darwin Darwin specific

Comments

@ocboogie
Copy link

ocboogie commented Apr 20, 2021

Most people on Mac wouldn't actually use the ~/Library/Application Support directory but rather ~/.config (see xdg-rs/dirs#45). This allows people to use their dotfiles on Linux and Mac. We could either make a breaking change and not use ~/Library/Application Support or we could check both directories for the config file. However, if we go the route of #283, there would have to be a decision to make: create the default config in ~/Library/Application Support or ~/.config.

Related:
xdg-rs/dirs#45
#283

@ocboogie ocboogie changed the title Feature(Config): Feature(Config): Check XDG Config Directory on Mac Apr 20, 2021
@qballer
Copy link
Member

qballer commented Apr 22, 2021

I'm for r ~/.config

@a-kenji a-kenji added darwin Darwin specific config Improvements to the configuration system labels Apr 22, 2021
@a-kenji
Copy link
Contributor

a-kenji commented Apr 27, 2021

@ocboogie

This check should be now on main, can you please confirm that it works?
It checks after /Users/Alice/Library/Application Support/org.Zellij-Contributors.zellij,
so if you have that directory it will still load from there.

@a-kenji
Copy link
Contributor

a-kenji commented May 11, 2021

This should be adressed.

@a-kenji a-kenji closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Improvements to the configuration system darwin Darwin specific
Projects
None yet
Development

No branches or pull requests

3 participants