Skip to content

Commit aef4014

Browse files
committed
fix: fix a11y autogenerated IDs to not return undefined
After the migration to Garden v9 in #688, I noticed that some a11y labels were displayed as `undefined--label` This is caused by a [bug](zendeskgarden/react-components#2057) in `@zendeskgarden/container-utilities` v2.0.3 that causes autogenerated IDs to return `undefined`, which breaks accessibility in several places. This happens only with React < 18. We are reverting to v2.0.2 until the issue is fixed, setting a resolution in the `package.json` to ensure that v2.0.3 is not installed. We will need to remove this resolution in the future when a proper fix is released. This is not ideal, but right now there are no other options other than reverting the migration to v9.
1 parent 9be8842 commit aef4014

File tree

2 files changed

+3
-41
lines changed

2 files changed

+3
-41
lines changed

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@
110110
},
111111
"resolutions": {
112112
"@types/react": "^17.x",
113-
"nwsapi": "^2.2.20"
113+
"nwsapi": "^2.2.20",
114+
"@zendeskgarden/container-utilities": "2.0.2"
114115
},
115116
"commitlint": {
116117
"extends": [

yarn.lock

Lines changed: 1 addition & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -5380,33 +5380,7 @@ __metadata:
53805380
languageName: node
53815381
linkType: hard
53825382

5383-
"@zendeskgarden/container-utilities@npm:^1.0.12":
5384-
version: 1.0.12
5385-
resolution: "@zendeskgarden/container-utilities@npm:1.0.12"
5386-
dependencies:
5387-
"@babel/runtime": "npm:^7.8.4"
5388-
"@reach/auto-id": "npm:^0.18.0"
5389-
peerDependencies:
5390-
react: ">=16.8.0"
5391-
react-dom: ">=16.8.0"
5392-
checksum: 10c0/a26837e187ad2b56666b65026f84e86ee429ae22d0f3041529ebac21605823041b95650f0ce428b571ce4c80fe4d0a874fd825b2d6bff1bb125c9dfc9cabecef
5393-
languageName: node
5394-
linkType: hard
5395-
5396-
"@zendeskgarden/container-utilities@npm:^2.0.0":
5397-
version: 2.0.0
5398-
resolution: "@zendeskgarden/container-utilities@npm:2.0.0"
5399-
dependencies:
5400-
"@babel/runtime": "npm:^7.8.4"
5401-
"@reach/auto-id": "npm:^0.18.0"
5402-
peerDependencies:
5403-
react: ">=16.8.0"
5404-
react-dom: ">=16.8.0"
5405-
checksum: 10c0/4bfd3485107e823263278dc7d5449ce28c636198abd8fe920b737f5e68700c15ef6d011bde377a7750a6eb193d78a36d953945571e10e759028215b6596ac262
5406-
languageName: node
5407-
linkType: hard
5408-
5409-
"@zendeskgarden/container-utilities@npm:^2.0.2":
5383+
"@zendeskgarden/container-utilities@npm:2.0.2":
54105384
version: 2.0.2
54115385
resolution: "@zendeskgarden/container-utilities@npm:2.0.2"
54125386
dependencies:
@@ -5419,19 +5393,6 @@ __metadata:
54195393
languageName: node
54205394
linkType: hard
54215395

5422-
"@zendeskgarden/container-utilities@npm:^2.0.3":
5423-
version: 2.0.3
5424-
resolution: "@zendeskgarden/container-utilities@npm:2.0.3"
5425-
dependencies:
5426-
"@babel/runtime": "npm:^7.8.4"
5427-
"@reach/auto-id": "npm:^0.18.0"
5428-
peerDependencies:
5429-
react: ^16.8.0 || ^17.0.0 || ^18.0.0
5430-
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0
5431-
checksum: 10c0/fbfe8b2b05a6fab07bec8c84b98f9a7896419a622a03c8b6be21792cce5b6c197315a16460fdd520bd0d1fe10b9978b8e67c2376d44ab1786f19e8202f95caf7
5432-
languageName: node
5433-
linkType: hard
5434-
54355396
"@zendeskgarden/css-variables@npm:6.4.6":
54365397
version: 6.4.6
54375398
resolution: "@zendeskgarden/css-variables@npm:6.4.6"

0 commit comments

Comments
 (0)