Update quill dependency to v2 #507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We will definitely do this once the stable version is released |
Author
|
I think that could be a branch in your repository so that it is easier to find for those who want to use react-quill with quill v2. Also this would allow to work on quill v2 support iteratively while it is being developed instead of doing everything after release. This could speed up the delivery of the updated react-quill. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quill v2 is still in development, however it contains some important fixes and therefore it might be preferable to use the up-to-date version.
In this PR besides the version bump I added a change to the
clipboard.convertcall where API changed in quill v2. For the moment it seems to me to be enough to make v2 work, but if I notice anything else I'll update my pull request.