-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Anchor.js usability (for on-hover anchor links) #84
Comments
Further to #82, now I see why you're using
Yes -
Mermaid is designed to work in light dom context. It's probably not their remit - if feels like something that I'll need to add as a feature (to make it work in |
Why? AnchorJS is for adding the links to the document tree. Since AnchorJS uses #83 simply fixed the scrolling in light-DOM. AnchorJS is still required to add the links to the tree. |
Ah I see - I misunderstood what |
That is what I'm currently doing :), but AnchorJS implementation means I must use zero-md with |
YUp that's right - unfortunately it'll need to be in |
I would like to use AnchorJS with zero-md.
This adds the little anchors to headings, so you can click them to link to the heading from elsewhere. e.g., in all GitHub markdown. i.e.,
They suggest using it like
However, it selects the headings using
document.querySelectorAll
https://github.com/bryanbraun/anchorjs/blob/7820d5f6a6d41eb92000ab9c22b9362262a6b8a8/anchor.js#L274-L286
From what I understand about shadow DOMs, this is incompatible with the way zero-md works.
Am I right in thinking this way?
Mermaid similarities
It seems similar to how Mermaid is currently suggested to be used:
#65
https://zerodevx.github.io/zero-md/recipes/#support-mermaid-diagrams
For now, I must disable the shadow DOM. #82 currently breaks this.
Should it be in the remit of these external libraries (Mermaid/AnchorJS) to allow use with the shadow DOM, or is it just something that will never be supported by them?
The text was updated successfully, but these errors were encountered: