Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Build with MinGW-64 failed on windres command #4742

Open
asschmidt opened this issue Sep 15, 2024 · 0 comments
Open

Windows Build with MinGW-64 failed on windres command #4742

asschmidt opened this issue Sep 15, 2024 · 0 comments

Comments

@asschmidt
Copy link

Issue description

Building libzmq under Windows 10 with MinGW-64 is failing on the call of windres due to the usage of wrong command line parameters/syntax.

It seems that the check in CMakeList.txt line 1186 fails because of upper/lower case issue

Original code from CMakeList.txt
if(CMAKE_SYSTEM_PROCESSOR MATCHES "i386"
OR CMAKE_SYSTEM_PROCESSOR MATCHES "i486"
OR CMAKE_SYSTEM_PROCESSOR MATCHES "i586"
OR CMAKE_SYSTEM_PROCESSOR MATCHES "i686"
OR CMAKE_SYSTEM_PROCESSOR MATCHES "x86"
OR CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64"
OR CMAKE_SYSTEM_PROCESSOR MATCHES "amd64")

On my machine the CMAKE_SYSTEM_PROCESSOR variable has a value of "AMD64". After adding this uppercase value to the CMakeFile check on line 1186 the build works.

Environment

  • libzmq version (commit hash if unreleased): 4.3.5
  • OS: Windows 10
  • CMake Version 3.30.3

Minimal test code / Steps to reproduce the issue

  1. cmake -G"MinGW Makefiles" -DCMAKE_SYSTEM_NAME=WindowsStore -DCMAKE_SYSTEM_VERSION=10.0 -DENABLE_CURVE=OFF -DZMQ_BUILD_TESTS=OFF -DMINGW=ON ..
  2. mingw32-make

What's the actual result? (include assertion message & call stack if applicable)

Fail on windres call

What's the expected result?

Successfull build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant