Skip to content

Commit d7020e7

Browse files
committed
ci: download pack after checkout + enable node 10
1 parent 1257c49 commit d7020e7

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

.github/workflows/CI.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -239,14 +239,9 @@ jobs:
239239
- macos-14
240240
- macos-13
241241
node-version:
242-
# - 10
242+
- 10
243243
- 22
244244
steps:
245-
- name: Download Pack
246-
uses: actions/download-artifact@v4
247-
with:
248-
name: pack
249-
250245
- name: Install Node
251246
uses: actions/setup-node@v4
252247
with:
@@ -276,5 +271,10 @@ jobs:
276271

277272
- uses: actions/checkout@v4
278273

274+
- name: Download Pack
275+
uses: actions/download-artifact@v4
276+
with:
277+
name: pack
278+
279279
- name: Smoke Test
280280
run: bash ./script/smoke-test.bash

script/smoke-test.bash

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ echo "Pack zeromq.js if needed"
66
version=$(node -e 'console.log(require("./package.json").version)')
77
pack_name="zeromq-${version}.tgz"
88
echo "${pack_name}"
9-
test -f "${pack_name}" || ls -R
9+
test -f "${pack_name}" || npm pack
1010

1111
init_smoke_test() {
1212
local pm=$1
@@ -15,8 +15,8 @@ init_smoke_test() {
1515
rm -rf "./smoke-test-${pm}"
1616
mkdir "./smoke-test-${pm}"
1717
cd "./smoke-test-${pm}"
18-
npm init -q --init-module "smoke-test-${pm}" -y
19-
npm pkg set dependencies.zeromq="file:../${pack_name}" || (jq '.dependencies.zeromq = "file:../${pack_name}"' package.json >temp.json && mv temp.json package.json)
18+
npm init -y
19+
npm pkg set dependencies.zeromq="file:../${pack_name}" || jq '.dependencies.zeromq = "file:../${pack_name}"' package.json >temp.json && mv temp.json package.json
2020
}
2121

2222
package_managers=(npm pnpm yarn)

0 commit comments

Comments
 (0)