Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zetacore : Identifier naming refactors #3098

Open
kingpinXD opened this issue Nov 5, 2024 · 0 comments
Open

zetacore : Identifier naming refactors #3098

kingpinXD opened this issue Nov 5, 2024 · 0 comments

Comments

@kingpinXD
Copy link
Contributor

kingpinXD commented Nov 5, 2024

This task lists a number of refactors that can to be done to the node code, to make it more readable .

  1. Rename all instances of Tss to TSS.
    https://github.com/zeta-chain/zeta-node/blob/5d6891773974fb91100812df629465abbdc0ac0e/testutil/sample/observer.go#L123-L139

  2. Rename Identifieriers for store keys to match the value they are storing
    VoterKey -> BallotKey
    AllChainParamsKey -> ChainParamsListKey
    LastBlockObserverCountKey -> LastObserverCountKey
    BallotListKey -> BallotListForHeightKey
    TssFundMigratorInfoKey -> TssFundMigratorKey
    PendingNoncesKeyPrefix -> PendingNoncesListKey
    NonceToCctxKeyPrefix -> NonceToCctxListKey

  3. Remove unsed keys

  4. We use AuthKeeper for authtypes.AccountKeeper and AuthorityKeeper for authoritytypes.Keeper . Throughout the code . The naming is confusing and should be changed
    We can use
    AccountKeeper for authtypes.AccountKeeper
    AuthorityKeeper for authoritytypes.Keeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant