Skip to content

Commit 172caf1

Browse files
committed
kbuild: remove redundant target cleaning on failure
Since commit 9c2af1c ("kbuild: add .DELETE_ON_ERROR special target"), the target file is automatically deleted on failure. The boilerplate code ... || { rm -f $@; false; } is unneeded. Signed-off-by: Masahiro Yamada <[email protected]>
1 parent f568866 commit 172caf1

File tree

9 files changed

+16
-25
lines changed

9 files changed

+16
-25
lines changed

Diff for: arch/arm/boot/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ targets := Image zImage xipImage bootpImage uImage
3232
ifeq ($(CONFIG_XIP_KERNEL),y)
3333

3434
cmd_deflate_xip_data = $(CONFIG_SHELL) -c \
35-
'$(srctree)/$(src)/deflate_xip_data.sh $< $@ || { rm -f $@; false; }'
35+
'$(srctree)/$(src)/deflate_xip_data.sh $< $@'
3636

3737
ifeq ($(CONFIG_XIP_DEFLATED_DATA),y)
3838
quiet_cmd_mkxip = XIPZ $@

Diff for: arch/arm/boot/compressed/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ check_for_bad_syms = \
170170
bad_syms=$$($(CROSS_COMPILE)nm $@ | sed -n 's/^.\{8\} [bc] \(.*\)/\1/p') && \
171171
[ -z "$$bad_syms" ] || \
172172
( echo "following symbols must have non local/private scope:" >&2; \
173-
echo "$$bad_syms" >&2; rm -f $@; false )
173+
echo "$$bad_syms" >&2; false )
174174

175175
check_for_multiple_zreladdr = \
176176
if [ $(words $(ZRELADDR)) -gt 1 -a "$(CONFIG_AUTO_ZRELADDR)" = "" ]; then \

Diff for: arch/arm/tools/Makefile

+1-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ _dummy := $(shell [ -d '$(kapi)' ] || mkdir -p '$(kapi)') \
3535

3636
quiet_cmd_gen_mach = GEN $@
3737
cmd_gen_mach = mkdir -p $(dir $@) && \
38-
$(AWK) -f $(filter-out $(PHONY),$^) > $@ || \
39-
{ rm -f $@; /bin/false; }
38+
$(AWK) -f $(filter-out $(PHONY),$^) > $@
4039

4140
$(kapi)/mach-types.h: $(src)/gen-mach-types $(src)/mach-types FORCE
4241
$(call if_changed,gen_mach)

Diff for: arch/sh/tools/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313
include/generated/machtypes.h: $(src)/gen-mach-types $(src)/mach-types
1414
@echo ' Generating $@'
1515
$(Q)mkdir -p $(dir $@)
16-
$(Q)LC_ALL=C $(AWK) -f $^ > $@ || { rm -f $@; /bin/false; }
16+
$(Q)LC_ALL=C $(AWK) -f $^ > $@

Diff for: arch/x86/boot/compressed/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ suffix-$(CONFIG_KERNEL_LZO) := lzo
151151
suffix-$(CONFIG_KERNEL_LZ4) := lz4
152152

153153
quiet_cmd_mkpiggy = MKPIGGY $@
154-
cmd_mkpiggy = $(obj)/mkpiggy $< > $@ || ( rm -f $@ ; false )
154+
cmd_mkpiggy = $(obj)/mkpiggy $< > $@
155155

156156
targets += piggy.S
157157
$(obj)/piggy.S: $(obj)/vmlinux.bin.$(suffix-y) $(obj)/mkpiggy FORCE

Diff for: arch/x86/lib/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ KCOV_INSTRUMENT_delay.o := n
99
inat_tables_script = $(srctree)/arch/x86/tools/gen-insn-attr-x86.awk
1010
inat_tables_maps = $(srctree)/arch/x86/lib/x86-opcode-map.txt
1111
quiet_cmd_inat_tables = GEN $@
12-
cmd_inat_tables = $(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@
12+
cmd_inat_tables = $(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@
1313

1414
$(obj)/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
1515
$(call cmd,inat_tables)

Diff for: certs/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ $(obj)/system_certificates.o: $(obj)/x509_certificate_list
2222
AFLAGS_system_certificates.o := -I$(srctree)
2323

2424
quiet_cmd_extract_certs = EXTRACT_CERTS $(patsubst "%",%,$(2))
25-
cmd_extract_certs = scripts/extract-cert $(2) $@ || ( rm $@; exit 1)
25+
cmd_extract_certs = scripts/extract-cert $(2) $@
2626

2727
targets += x509_certificate_list
2828
$(obj)/x509_certificate_list: scripts/extract-cert $(SYSTEM_TRUSTED_KEYS_SRCPREFIX)$(SYSTEM_TRUSTED_KEYS_FILENAME) FORCE

Diff for: lib/raid6/Makefile

+2-3
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ raid6_pq-$(CONFIG_S390) += s390vx8.o recov_s390xc.o
1313
hostprogs-y += mktables
1414

1515
quiet_cmd_unroll = UNROLL $@
16-
cmd_unroll = $(AWK) -f$(srctree)/$(src)/unroll.awk -vN=$(UNROLL) \
17-
< $< > $@ || ( rm -f $@ && exit 1 )
16+
cmd_unroll = $(AWK) -f$(srctree)/$(src)/unroll.awk -vN=$(UNROLL) < $< > $@
1817

1918
ifeq ($(CONFIG_ALTIVEC),y)
2019
altivec_flags := -maltivec $(call cc-option,-mabi=altivec)
@@ -160,7 +159,7 @@ $(obj)/s390vx8.c: $(src)/s390vx.uc $(src)/unroll.awk FORCE
160159
$(call if_changed,unroll)
161160

162161
quiet_cmd_mktable = TABLE $@
163-
cmd_mktable = $(obj)/mktables > $@ || ( rm -f $@ && exit 1 )
162+
cmd_mktable = $(obj)/mktables > $@
164163

165164
targets += tables.c
166165
$(obj)/tables.c: $(obj)/mktables FORCE

Diff for: scripts/Makefile.lib

+7-14
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,7 @@ cmd_objcopy = $(OBJCOPY) $(OBJCOPYFLAGS) $(OBJCOPYFLAGS_$(@F)) $< $@
242242
# ---------------------------------------------------------------------------
243243

244244
quiet_cmd_gzip = GZIP $@
245-
cmd_gzip = (cat $(filter-out FORCE,$^) | gzip -n -f -9 > $@) || \
246-
(rm -f $@ ; false)
245+
cmd_gzip = cat $(filter-out FORCE,$^) | gzip -n -f -9 > $@
247246

248247
# DTC
249248
# ---------------------------------------------------------------------------
@@ -336,26 +335,22 @@ printf "%08x\n" $$dec_size | \
336335

337336
quiet_cmd_bzip2 = BZIP2 $@
338337
cmd_bzip2 = (cat $(filter-out FORCE,$^) | \
339-
bzip2 -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
340-
(rm -f $@ ; false)
338+
bzip2 -9 && $(call size_append, $(filter-out FORCE,$^))) > $@
341339

342340
# Lzma
343341
# ---------------------------------------------------------------------------
344342

345343
quiet_cmd_lzma = LZMA $@
346344
cmd_lzma = (cat $(filter-out FORCE,$^) | \
347-
lzma -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
348-
(rm -f $@ ; false)
345+
lzma -9 && $(call size_append, $(filter-out FORCE,$^))) > $@
349346

350347
quiet_cmd_lzo = LZO $@
351348
cmd_lzo = (cat $(filter-out FORCE,$^) | \
352-
lzop -9 && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
353-
(rm -f $@ ; false)
349+
lzop -9 && $(call size_append, $(filter-out FORCE,$^))) > $@
354350

355351
quiet_cmd_lz4 = LZ4 $@
356352
cmd_lz4 = (cat $(filter-out FORCE,$^) | \
357-
lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
358-
(rm -f $@ ; false)
353+
lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@
359354

360355
# U-Boot mkimage
361356
# ---------------------------------------------------------------------------
@@ -399,13 +394,11 @@ quiet_cmd_uimage = UIMAGE $@
399394
quiet_cmd_xzkern = XZKERN $@
400395
cmd_xzkern = (cat $(filter-out FORCE,$^) | \
401396
sh $(srctree)/scripts/xz_wrap.sh && \
402-
$(call size_append, $(filter-out FORCE,$^))) > $@ || \
403-
(rm -f $@ ; false)
397+
$(call size_append, $(filter-out FORCE,$^))) > $@
404398

405399
quiet_cmd_xzmisc = XZMISC $@
406400
cmd_xzmisc = (cat $(filter-out FORCE,$^) | \
407-
xz --check=crc32 --lzma2=dict=1MiB) > $@ || \
408-
(rm -f $@ ; false)
401+
xz --check=crc32 --lzma2=dict=1MiB) > $@
409402

410403
# ASM offsets
411404
# ---------------------------------------------------------------------------

0 commit comments

Comments
 (0)