Skip to content

feat: add keys systemd serviceName option #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amerocu
Copy link

@amerocu amerocu commented Apr 5, 2025

Adds a new option in the keys attribute set to override the key service name. The default service name remains the name of the key suffixed with "-key" BUT the semantics changes a bit.

With this key declaration:

{
  deployment.keys.my-secret {
    name = "my-pretty-secret";
    ....
  } 
}

Before the service would have called my-secret-key while then it will be called my-pretty-secret-key. I think it's better to use the actual value of key name instead of the default value for the option key name.

This change also allows referring to the service name with the option config.deployment.keys.my-secret.serviceName in other services.

Fixes #141

Open Source Saturday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose 'service' field for deployment keys
1 participant