Send 413 reply on body too large

karlseguin#107

Author: karlseguin

src/httpz.zig

@@ -964,6 +964,15 @@ test "httpz: invalid content length value (2)" {
     try t.expectString("HTTP/1.1 400 \r\nConnection: Close\r\nContent-Length: 15\r\n\r\nInvalid Request", testReadAll(stream, &buf));
 }
 
+test "httpz: body too big" {
+    const stream = testStream(5993);
+    defer stream.close();
+    try stream.writeAll("POST / HTTP/1.1\r\nContent-Length: 999999999999999999\r\n\r\n");
+
+    var buf: [100]u8 = undefined;
+    try t.expectString("HTTP/1.1 413 \r\nConnection: Close\r\nContent-Length: 23\r\n\r\nRequest body is too big", testReadAll(stream, &buf));
+}
+
 test "httpz: overflow content length" {
     const stream = testStream(5992);
     defer stream.close();

src/request.zig

@@ -975,7 +975,6 @@ pub const State = struct {
         if (cl == 0) return true;
 
         if (self.lazy_read_size == null and cl > self.max_body_size) {
-            metrics.bodyTooBig();
             return error.BodyTooBig;
         }
 

src/worker.zig

@@ -1721,6 +1721,10 @@ fn requestError(conn: *HTTPConn, err: anyerror) !void {
             metrics.invalidRequest();
             return writeError(handle, 400, "Invalid Request");
         },
+        error.BodyTooBig => {
+            metrics.bodyTooBig();
+            return writeError(handle, 413, "Request body is too big");
+        },
         error.BrokenPipe, error.ConnectionClosed, error.ConnectionResetByPeer => return,
         else => {
             log.err("server error: {}", .{err});