Semantic highlight for static variable in neovim has extra `Constant` highlighting.

[doongjohn]

Zig Version

0.15.0-dev.386+2e35fdd03

ZLS Version

0.15.0-dev.73+2750757

Client / Code Editor / Extensions

nvim 0.11.0

Steps to Reproduce and Observed Behavior

var debug_allocator: std.heap.DebugAllocator(.{}) = .init;

Variable debug_allocator has extra Constant highlight with priority 128.

Expected Behavior

It should not have that highlighting.

Relevant log output

[Techatrix]

If the issue is specifically about the different highlighting of debug_allocator. That's a side effect of #2260 which adds the static token modifier to declarations that are in a non-local namespace. This can be observed in the @lsp.typemod.variable.static.zig links to Constant line. ZLS does not control what it links to or how it is highlighted.

To figure out what is adding the Constant priority: 128 entry, I tested ZLS in neovim 0.11.0 with the following config:

-- init.lua
vim.lsp.config['zls'] = {
    -- replace with path to zls or set to 'zls' if in $PATH
    cmd = { '/home/techatrix/repos/zls/zig-out/bin/zls' },
    filetypes = { 'zig' },
    root_markers = { 'build.zig' },
    settings = {
        zls = {
            -- replace with path to zig or omit if in $PATH
            zig_exe_path = '/nix/store/figbx3530fg8m6b1mfd9mvd9cpc141z3-zig-0.14.0/bin/zig'
        }
    },
}
vim.lsp.enable('zls')

const std = @import("std");
var debug_allocator: std.heap.DebugAllocator(.{}) = .init;

Running :Inspect on debug_allocator gave the following:

Semantic Tokens
  - @lsp.type.variable.zig links to @lsp.type.variable   priority: 125
  - @lsp.mod.declaration.zig links to @lsp   priority: 126
  - @lsp.mod.mutable.zig links to @lsp   priority: 126
  - @lsp.mod.static.zig links to @lsp   priority: 126
  - @lsp.typemod.variable.declaration.zig links to @lsp   priority: 127
  - @lsp.typemod.variable.mutable.zig links to @lsp   priority: 127
  - @lsp.typemod.variable.static.zig links to Constant   priority: 127

I also tried to install https://github.com/nvim-treesitter/nvim-treesitter but it only added the one entry in the new "Treesitter" section. The Constant priority: 128 entry is unlikely to be from ZLS since it emits no LSP token type or modifier named "constant". All the other entries that start with @lsp. do translate to LSP token types and modifiers emitted by ZLS.

Could you check whether the given config gives you the same result?

[doongjohn]

It was my nvim config 🤦

vim.api.nvim_create_autocmd("LspTokenUpdate", {
  group = "config",
  callback = function(args)
  	local token = args.data.token
  
  	if token.type == "variable" then
  		if token.modifiers.static then
  			vim.lsp.semantic_tokens.highlight_token(token, args.buf, args.data.client_id, "Constant")
  		end
  	end
    end,
})