Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom annotations to node svc #133

Open
artesby opened this issue Oct 18, 2024 · 0 comments
Open

Allow custom annotations to node svc #133

artesby opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@artesby
Copy link

artesby commented Oct 18, 2024

Currently datanode, indexnode, querynode does not allow additional service annotations like

{{- with .Values.service.annotations }}
  annotations:
{{ toYaml . | indent 4 }}

why: currently monitoring supports only prometheus way via servicemonitor. With annotations, one could use vmagent to scrape services based on annotations.
@haorenfsa haorenfsa added enhancement New feature or request good first issue Good for newcomers labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artesby @haorenfsa