Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze x264 version. #80

Open
Zalewa opened this issue Jun 20, 2018 · 1 comment
Open

Freeze x264 version. #80

Zalewa opened this issue Jun 20, 2018 · 1 comment

Comments

@Zalewa
Copy link
Collaborator

Zalewa commented Jun 20, 2018

Currently all libraries are fixed on a specific version except for the x264 library for which the "last" snapshot is always downloaded. This means that the ffmpeg build is non-deterministic and the resulting ffmpeg binaries depend on the day on which they were compiled, even though the version of ffmpeg itself is fixed too. Moreover, the whole build can suddenly break if the "last" snapshot of x264 changes something that breaks the current build scheme.

I propose to pick a specific x264 version and stick to it for the time being and only update it manually once in a while under controlled circumstances where it will be possible to verify if the new version breaks something. Given that all snapshots are good, picking any snapshot (even the newest one) will be fine.

@zimbatm
Copy link
Owner

zimbatm commented Jun 21, 2018

Yes, this is a great idea.

Bonus points for adding a little script that resolves the ref sha1 from the branch for you and thus makes it easy to bump the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants