ACM-10339 Show syntax errors on save in search YAML editor (stolostro…

…n#3346) Signed-off-by: zlayne <[email protected]>
zlayne · Mar 11, 2024 · a264525 · a264525
1 parent 22fae8d
commit a264525
Showing 1 changed file with 17 additions and 9 deletions.
diff --git a/frontend/src/routes/Home/Search/Details/YAMLPage.tsx b/frontend/src/routes/Home/Search/Details/YAMLPage.tsx
@@ -89,15 +89,21 @@ function updateResource(
   setResourceVersion: Dispatch<SetStateAction<string>>
 ) {
   if (cluster === 'local-cluster') {
-    replaceResource(jsYaml.load(resourceYaml) as IResource)
-      .promise.then(() => {
-        loadResource(cluster, kind, apiversion, name, namespace, setResourceYaml, setUpdateError, setResourceVersion)
-        setUpdateSuccess(true)
-      })
-      .catch((err) => {
-        console.error('Error updating resource: ', err)
-        setUpdateError(err.message)
-      })
+    try {
+      const parsedYaml = jsYaml.load(resourceYaml) as IResource
+      replaceResource(parsedYaml)
+        .promise.then(() => {
+          loadResource(cluster, kind, apiversion, name, namespace, setResourceYaml, setUpdateError, setResourceVersion)
+          setUpdateSuccess(true)
+        })
+        .catch((err) => {
+          console.error('Error updating resource: ', err)
+          setUpdateError(err.message)
+        })
+    } catch (err: any) {
+      console.error('Error updating resource: ', err)
+      setUpdateError(err?.message)
+    }
   } else {
     fireManagedClusterAction('Update', cluster, kind, apiversion, name, namespace, jsYaml.loadAll(resourceYaml)[0])
       .then((actionResponse) => {
@@ -211,6 +217,8 @@ export function EditorActionBar(props: {
               variant="primary"
               id="update-resource-button"
               onClick={() => {
+                setUpdateError('')
+                setUpdateSuccess(false)
                 updateResource(
                   cluster,
                   kind,