Skip to content

feat: preserve leading whitespace in INI keys #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

feat: preserve leading whitespace in INI keys #144

wants to merge 0 commits into from

Conversation

prestomation
Copy link
Contributor

@prestomation prestomation commented Jun 11, 2025 •
edited
Loading

Implements #126

  • Add support for indented keys (e.g., ' endpoint_url=value')
  • Preserve leading spaces/tabs in key names during parse/write cycles
  • Add whitespace parsing to handle key indentation
  • Maintain backward compatibility with existing INI files
  • Add tests for various indentation scenarios

This enables support for configuration formats like AWS config files that use indented keys for hierarchical organization.

@zonyitoo
Copy link
Owner

Excellent. But some tests are failed.

@prestomation
Copy link
Contributor Author

My apologies, I didn't pay enough attention to what targets would run in CI. I have updated the PR.

@zonyitoo
Copy link
Owner

You may have missed the CR;LF; compatibility (commonly used on Windows).

@prestomation
Copy link
Contributor Author

Sorry for the noise, replaced by #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestomation @zonyitoo