(bug) Fix duplicate file extension printed during create

Author: zph

runbook/cli/commands/create.py

@@ -3,11 +3,19 @@
 import click
 
 from runbook.cli.lib import nbconvert_launch_instance
-from runbook.cli.validators import validate_create_language, validate_template
+from runbook.cli.validators import (
+    validate_create_language,
+    validate_has_notebook_extension,
+    validate_template,
+)
 
 
 @click.command()
-@click.argument("filename", type=click.Path(exists=False, file_okay=True))
+@click.argument(
+    "filename",
+    type=click.Path(exists=False, file_okay=True),
+    callback=validate_has_notebook_extension,
+)
 @click.option(
     "-t",
     "--template",
@@ -76,6 +84,6 @@ def create(ctx, filename, template, language):
 
     click.echo(
         click.style(
-            f"$> runbook edit ./runbooks/binder/{filename}.ipynb", fg="green", bold=True
+            f"$> runbook edit ./runbooks/binder/{filename}", fg="green", bold=True
         )
     )

runbook/cli/validators.py

@@ -78,11 +78,14 @@ def process_glob_matches(options):
         raise click.BadOptionUsage("FILENAME", f"unable to find {value} file")
 
 
-def validate_planned_runbook_file_path(ctx, param, value):
-    ext = path.splitext(value)[-1].lower()
-    if not ext == ".ipynb":
-        ext = ".ipynb"
+def validate_has_notebook_extension(ctx, param, value):
+    if not value.lower().endswith(".ipynb"):
         value = value + ".ipynb"
+    return value
+
+
+def validate_planned_runbook_file_path(ctx, param, value):
+    value = validate_has_notebook_extension(ctx, param, value)
     base_name = path.basename(value)
     try:
         if Path(value).exists():