You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
The ZIA module, in the function getPaginatedData(), returns the data collected so far when it encounters an unexpected HTTP status code. I would rather see it raise an exception because it is now unclear whether all data is collected, which makes it cumbersome to design the right control flow.
get() instead raises an exception if an unexpected status code is returned.
Reproduction
When running ZIAClientHelper.users.list(), if an error is returned by one of the pages, which seemingly happens randomly at times (we have another ticket open about that), it ends up returning the list gathered so far, instead of throwing an error. It is difficult to extrapolate from the returned list whether it is complete or not. If instead an error were returned it would at least be clear that retrieving the list failed.
Expected behavior
getPaginatedData() raises an exception if the API returns an unexpected value.
Is it a regression?
N.A.
Debug Logs
Can be provided via ticket if need be
Other Information
Version: 0.10.3
Runs in automated pipeline
Additional context
N.A.
The text was updated successfully, but these errors were encountered:
Description
The ZIA module, in the function getPaginatedData(), returns the data collected so far when it encounters an unexpected HTTP status code. I would rather see it raise an exception because it is now unclear whether all data is collected, which makes it cumbersome to design the right control flow.
get() instead raises an exception if an unexpected status code is returned.
Reproduction
When running ZIAClientHelper.users.list(), if an error is returned by one of the pages, which seemingly happens randomly at times (we have another ticket open about that), it ends up returning the list gathered so far, instead of throwing an error. It is difficult to extrapolate from the returned list whether it is complete or not. If instead an error were returned it would at least be clear that retrieving the list failed.
Expected behavior
getPaginatedData() raises an exception if the API returns an unexpected value.
Is it a regression?
N.A.
Debug Logs
Can be provided via ticket if need be
Other Information
Additional context
N.A.
The text was updated successfully, but these errors were encountered: