packageInfo: add fallback logic test for appBundleId

add test for falling back to default value of appBundleId incase packageInfo is null

Author: Abhisheksainii

lib/model/binding.dart

@@ -303,10 +303,12 @@ class LinuxDeviceInfo implements BaseDeviceInfo {
 class PackageInfo {
   final String version;
   final String buildNumber;
+  final String packageName;
 
   const PackageInfo({
     required this.version,
     required this.buildNumber,
+    required this.packageName,
   });
 }
 
@@ -411,6 +413,7 @@ class LiveZulipBinding extends ZulipBinding {
       _syncPackageInfo = PackageInfo(
         version: info.version,
         buildNumber: info.buildNumber,
+        packageName: info.packageName,
       );
     } catch (e, st) {
       assert(debugLog('Failed to prefetch package info: $e\n$st')); // TODO(log)

lib/notifications/receive.dart

@@ -149,8 +149,7 @@ class NotificationService {
         await addFcmToken(connection, token: token);
 
       case TargetPlatform.iOS:
-        const appBundleId = 'com.zulip.flutter'; // TODO(#407) find actual value live
-        await addApnsToken(connection, token: token, appid: appBundleId);
+        await addApnsToken(connection, token: token, appid: (await ZulipBinding.instance.packageInfo)?.packageName ?? "com.zulip.flutter");
 
       case TargetPlatform.linux:
       case TargetPlatform.macOS:

test/api/core_test.dart

@@ -460,7 +460,7 @@ void main() {
       });
     }
 
-    const packageInfo = PackageInfo(version: '0.0.1', buildNumber: '1');
+    const packageInfo = PackageInfo(version: '0.0.1', buildNumber: '1', packageName: 'com.zulip.flutter.test');
 
     const testCases = [
       ('ZulipFlutter/0.0.1+1 (Android 14)',             AndroidDeviceInfo(release: '14', sdkInt: 34),                      ),

test/api/route/notifications_test.dart

@@ -3,10 +3,14 @@ import 'package:http/http.dart' as http;
 import 'package:test/scaffolding.dart';
 import 'package:zulip/api/route/notifications.dart';
 
+import '../../model/binding.dart';
 import '../../stdlib_checks.dart';
 import '../fake_api.dart';
 
 void main() {
+
+  TestZulipBinding.ensureInitialized();
+
   group('addFcmToken', () {
     Future<void> checkAddFcmToken(FakeApiConnection connection, {
       required String token,
@@ -50,6 +54,12 @@ void main() {
   });
 
   group('addApnsToken', () {
+
+    Future<void> init() async {
+      addTearDown(testBinding.reset);
+      testBinding.firebaseMessagingInitialToken = '012abc';
+    }
+
     Future<void> checkAddApnsToken(FakeApiConnection connection, {
       required String token,
       required String appid,
@@ -70,6 +80,19 @@ void main() {
         await checkAddApnsToken(connection, token: 'asdf', appid: 'qwer');
       });
     });
+
+    test('Fallback to default appBundleId incase packageInfo is null', () async {
+        await init();
+        // setting package Info to null
+        testBinding.packageInfoResult=null;
+
+        const defaultAppId = 'com.zulip.flutter.test';
+
+        return FakeApiConnection.with_((connection) async {
+          await checkAddApnsToken(connection, token: 'asdf', appid:(await testBinding.packageInfo)?.packageName?? defaultAppId);
+        });
+    });
+
   });
 
   group('removeApnsToken', () {

test/model/binding.dart

@@ -228,8 +228,8 @@ class TestZulipBinding extends ZulipBinding {
   BaseDeviceInfo? get syncDeviceInfo => deviceInfoResult;
 
   /// The value that `ZulipBinding.instance.packageInfo` should return.
-  PackageInfo packageInfoResult = _defaultPackageInfo;
-  static const _defaultPackageInfo = PackageInfo(version: '0.0.1', buildNumber: '1');
+  PackageInfo? packageInfoResult = _defaultPackageInfo;
+  static const _defaultPackageInfo = PackageInfo(version: '0.0.1', buildNumber: '1', packageName: 'com.zulip.flutter.test');
 
   void _resetPackageInfo() {
     packageInfoResult = _defaultPackageInfo;
@@ -241,6 +241,7 @@ class TestZulipBinding extends ZulipBinding {
   @override
   PackageInfo? get syncPackageInfo => packageInfoResult;
 
+
   void _resetFirebase() {
     _firebaseInitialized = false;
     _firebaseMessaging = null;

test/model/store_test.dart

@@ -1032,7 +1032,7 @@ void main() {
       if (defaultTargetPlatform == TargetPlatform.android) {
         checkLastRequestFcm(token: '012abc');
       } else {
-        checkLastRequestApns(token: '012abc', appid: 'com.zulip.flutter');
+        checkLastRequestApns(token: '012abc', appid:'com.zulip.flutter.test');
       }
 
       if (defaultTargetPlatform == TargetPlatform.android) {
@@ -1071,7 +1071,7 @@ void main() {
       if (defaultTargetPlatform == TargetPlatform.android) {
         checkLastRequestFcm(token: '012abc');
       } else {
-        checkLastRequestApns(token: '012abc', appid: 'com.zulip.flutter');
+        checkLastRequestApns(token: '012abc', appid:'com.zulip.flutter.test');
       }
 
       if (defaultTargetPlatform == TargetPlatform.android) {

test/notifications/receive_test.dart

@@ -30,4 +30,6 @@ void main() {
         .length.equals(1);
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
   });
+
+
 }