-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus topic input first when opening compose box #1448
Comments
This comment has been minimized.
This comment has been minimized.
Wanted to contribute to this issue but the above solution I think should solve the problem well. |
@shkshreyas It looks like you asked ChatGPT or another LLM how to solve this issue, and then just pasted its response into the comment box. That isn't useful. @kelseafunwi Sure, welcome. Take a look at our guide to contributing to Zulip: |
This comment has been minimized.
This comment has been minimized.
I see why you were saying the code he gave was generated by AI 😂, I've been going through the codebase for about 5 hours now and haven't really seen how to get to that point. Still to continue working on it by evening. Hopefully, i'll get an understanding of that part of the code soon. |
Yep, finding one's way for the first time around any given codebase takes some effort 🙂. We have a little bit of advice on how to do that effectively in the section you're already reading: |
This comment has been minimized.
This comment has been minimized.
Hi everyone, Like, instead of requesting focus on the topic field when the compose box is tapped, shouldn't we make it a necessity for the user to enter something in the topic field before they can send the message, and disable the send message button until then? |
In a channel feed, if you tap the compose box and the topic input is empty (i.e. you haven't already entered something there), we'd like to put focus in the topic input instead of in the content input.
Chat thread here: #mobile > reply goes to "no topic" @ 💬
Background / motivation
This bit of user feedback started that same thread:
In the legacy app we effectively have the behavior this issue is calling for: when the compose box is closed, the topic input doesn't even appear, but once you touch it so it opens, your focus goes to the topic input.
References
autocomplete: Options list can persistently lag behind query #226
The text was updated successfully, but these errors were encountered: