Skip to content

compose: On recent servers, quote-and-reply doesn't fill empty topic input #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisbobbe opened this issue Apr 9, 2025 · 0 comments
Assignees
Labels
a-compose Compose box, autocomplete, attaching files/images

Comments

@chrisbobbe
Copy link
Collaborator

To reproduce:

  1. Connect to CZO or another realm with feature level 334+
  2. Enter a channel narrow
  3. Long-press a message; tap "Quote and reply"
  4. See the content input update with the quoted message

Expected: the topic input is automatically filled with the message's topic

Actual: the topic input remains blank


This looks like a regression from the recent "general chat" work. To check if the topic input was left empty, the quote-and-reply button checks the condition composeBoxController.topic.textNormalized == kNoTopicTopic. Before 769cc7d, that condition was a reliable test of whether the topic input was left empty. But it isn't reliable anymore; on recent servers, if the topic input is left empty, composeBoxController.topic.textNormalized will be the empty string.

Assigning @PIG208 as the author of 769cc7d.

@chrisbobbe chrisbobbe added the a-compose Compose box, autocomplete, attaching files/images label Apr 9, 2025
@chrisbobbe chrisbobbe added this to the M6: Post-launch milestone Apr 9, 2025
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Apr 14, 2025
The topic should be filled with the quoted message when it is vacuous,
not just when it is "(no topic)".

Fixes: zulip#1469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Status: No status
Development

No branches or pull requests

2 participants