Skip to content

compose: Implement disabled appearance for edit-message "Save" button #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisbobbe opened this issue Apr 23, 2025 · 0 comments
Open
Labels
a-compose Compose box, autocomplete, attaching files/images
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

When we first implement the edit-message compose box (#126), we plan to skip a feature that the regular compose box has, because we don't have a Figma design for it.

The regular compose box gives the "Send" button a faded appearance when there are validation errors. Compare:

Validation error (content too long) No validation error
Image Image

We should do the same with the "Save" button in the edit-message compose box:

Image

See ZulipWebUiKitButton in the code, and the Figma frames linked from there, which don't include a design for a disabled state.

Tapping the "Save" button still gives a dialog explaining the validation error(s), just like the regular compose box's "Send" button, which mitigates the bug a lot.

@chrisbobbe chrisbobbe added the a-compose Compose box, autocomplete, attaching files/images label Apr 23, 2025
@chrisbobbe chrisbobbe added this to the M7: Future milestone Apr 23, 2025
@chrisbobbe chrisbobbe changed the title compose: Implement disabled state for edit-message "Save" button compose: Implement disabled appearance for edit-message "Save" button Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Status: No status
Development

No branches or pull requests

1 participant