-
Notifications
You must be signed in to change notification settings - Fork 307
msglist: Adding 🙂 emoji reaction fails #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yeah, we should fix this. Presumably this is due to the recent server change to make U+1F642 🙂 be called The fix will probably involve updating this code: static final _popularCandidates = _generatePopularCandidates();
static List<EmojiCandidate> _generatePopularCandidates() {
// …
return [
// This list should match web:
// https://github.com/zulip/zulip/blob/83a121c7e/web/shared/src/typeahead.ts#L22-L29
candidate('1f44d', '👍', ['+1', 'thumbs_up', 'like']),
candidate('1f389', '🎉', ['tada']),
candidate('1f642', '🙂', ['smile']), The first step will be some refactoring to make that no longer static — it'll need to depend on |
Hi there, I have a workaround for this issue. But I see this has already been assigned to the author himself. Let me know if you've implemented this already. |
For zulip#1495, we'll want to keep the hard-coded list of emoji codes but get the names from ServerEmojiData. This refactor prepares for that by separating where we source the codes and the names.
…t it This brings the tests closer to being representative, because this data (and more) is part of the app's setup for an account on startup, via fetchServerEmojiData. For zulip#1495, the app will start depending on this data for the names of popular emoji. So, prepare for that by filling in the data in tests that would break without it.
The server change in zulip/zulip#34177, renaming `:smile:` to `:slight_smile:`, broke the corresponding reaction button in the message action sheet. We've been sending the add/remove-reaction request with the old name 'smile', which modern servers reject. To fix, take the popular emoji names from ServerEmojiData, so that we'll use the correct name on servers before and after the change. API-design discussion: https://chat.zulip.org/#narrow/channel/378-api-design/topic/.23F1495.20smile.2Fslight_smile.20change.20broke.20reaction.20button/near/2170354 Fixes: zulip#1495
Reproduced on CZO just now:
The text was updated successfully, but these errors were encountered: