Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After switching controllers, the node names and locations are attributed to the wrong devices #3817

Open
AlCalzone opened this issue Jul 19, 2024 · 6 comments

Comments

@AlCalzone
Copy link
Member

grafik

I previously had another stick connected with 3 nodes, using different IDs 2, 3 and 4, which had these names and locations set. After switching sticks, the names and locations persist in the UI, but they belong to the wrong devices.

@robertsLando
Copy link
Member

yeah this is expected, on init I load nodes.json and apply it to the existing devices, this is useful in case you restore your backup on a different controller to keep nodes names in sync. The alternative would be to store nodes along with the homeID. I accept suggestions here as this is not a very common use case and we should consider pro-cons of changing the actual behaviour

@AlCalzone
Copy link
Member Author

AlCalzone commented Jul 19, 2024

I think the node names should be stored separately for each home ID. Or you could use the properties from the node instance to have the driver handle it?

@robertsLando
Copy link
Member

Or you could use the properties from the node instance to have the driver handle it?

I actually pass down to the driver the name/location if I see them are different to the ones stored on nodes.json

That file exist for very old reasons as with OZW node name and location was not working everytime so I decided to keep them stored there. We could also decide to simply drop name/loc from that file as it is alsready stored on your json backup.

I also store home assistant custom devices on that file and that will remain

@AlCalzone
Copy link
Member Author

In any case, nodes belonging to a different home ID are very likely not the same devices. Especially if the Node ID also changed.

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

@github-actions github-actions bot added the Stale label Oct 18, 2024
Copy link
Contributor

This issue is now closed due to inactivity, you can of course reopen or reference this issue if you see fit.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
@robertsLando robertsLando reopened this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants