Cross targeting fails on Windows if target runtime contains symlinks

[aahlenst]

jlink.online/jlink_test.go

Line 106 in e0b932e

assertRequestSuccess(t, "http://localhost:8080/x64/linux/11.0.8+10?modules=java.base", "linux")

fails on Windows. The reason is that the tar.gz for Linux contains symlinks. Those cause archiver.Unarchive() to fail (as well as 7zip, so not archiver's fault) with the following error:

reading file in tar archive: C:\Users\andreas\AppData\Local\Temp\runtime_cache\OpenJDK11U-jdk_x64_linux_hotspot_11.0.8_10\jdk-11.0.8+10\legal\jdk.localedata\ASSEMBLY_EXCEPTION: making symbolic link for: symlink ..\java.base\ASSEMBLY_EXCEPTION C:\Users\andreas\AppData\Local\Temp\runtime_cache\OpenJDK11U-jdk_x64_linux_hotspot_11.0.8_10\jdk-11.0.8+10\legal\jdk.localedata\ASSEMBLY_EXCEPTION: A required privilege is not held by the client.

I'm not sure how to proceed here. https://pkg.go.dev/github.com/mholt/archiver/v3#TarGz has no option to ignore symlinks or continue on error. We could ignore the return code and continue no matter what, but I don't think this is desirable.

[cilki]

I had the same problem when creating an archive containing symlinks and added this line as a temporary solution:

jlink.online/jlink.go

Line 390 in 31321e3

_ = os.RemoveAll(filepath.FromSlash(output + "/legal"))

But I didn't have any problems extracting an archive with symlinks on Windows. I'll have to spin up a Windows VM and see what I can find.