Merge pull request #121 from CodebreakerApp/118-backendmodelupdates

118 update backend models

Author: christiannagel

.github/workflows/createnuget-withbuildnumber.yml

@@ -46,7 +46,7 @@ jobs:
 
     steps:
       - name: Checkout to the branch
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: ${{ inputs.branch-name }}
 

src/services/gameapi/Codebreaker.GameAPIs.Models/Codebreaker.GameAPIs.Models.csproj

@@ -13,7 +13,8 @@
       See https://github.com/codebreakerapp for more information on the complete solution.
     </Description>
     <PackageReadmeFile>readme.md</PackageReadmeFile>
-    <PackageIcon>codebreaker.jpeg</PackageIcon>   
+    <PackageIcon>codebreaker.jpeg</PackageIcon>
+    <IsAotCompatible>true</IsAotCompatible>
   </PropertyGroup>
 
   <ItemGroup>

src/services/gameapi/Codebreaker.GameAPIs.Models/Exceptions/CodebreakerException.cs

@@ -21,17 +21,19 @@ public static void ThrowIfNull([NotNull] Game? game)
         }
     }
 
-    public static void ThrowIfEnded(Game game)
+    public static void ThrowIfUnexpectedGameType(Game game, string gameType)
     {
-        if (game.Ended())
+        if (game.GameType != gameType)
         {
-            throw new CodebreakerException("Game is not active") { Code = CodebreakerExceptionCodes.GameNotActive };
+            throw new CodebreakerException("Game type not expected") { Code = CodebreakerExceptionCodes.UnexpectedGameType };
         }
     }
 
-    [DoesNotReturn]
-    public static void ThrowUpdateFailed(Game game)
+    public static void ThrowIfEnded(Game game)
     {
-        throw new CodebreakerException("Game update failed") { Code = CodebreakerExceptionCodes.GameUpdateFailed };
+        if (game.Ended())
+        {
+            throw new CodebreakerException("Game is not active") { Code = CodebreakerExceptionCodes.GameNotActive };
+        }
     }
 }

src/services/gameapi/Codebreaker.GameAPIs.Models/Exceptions/CodebreakerExceptionCodes.cs

@@ -3,6 +3,7 @@
 public class CodebreakerExceptionCodes
 {
     public const string InvalidGameType = nameof(InvalidGameType);
+    public const string UnexpectedGameType = nameof(UnexpectedGameType);
     public const string GameNotFound = nameof(GameNotFound);
     public const string GameNotActive = nameof(GameNotActive);
     public const string GameUpdateFailed = nameof(GameUpdateFailed);