[BUG] Changing DOLI_INSTANCE_UNIQUE_ID doesn't overridethe value on conf/conf.php

[cibero42]

This issue is related to the discussion on PR #60.

After testing the implementation of specifying the env DOLI_INSTANCE_UNIQUE_ID on already created enviornments, the value for $dolibarr_main_instance_unique_id= on conf/conf.php doesn't change.

This variable seems to be essential on CRON containers, and in order to temporarily fix the issue, it is required to manually change the value on conf/conf.php to match with the env

[cibero42]

Hello,

I've figured out the issue. I'll keep this one open, as I'll build a PR for it.

[creekorful]

Hello @cibero42,

This is expected because currently the docker-run.sh script does not update the config file if it already exists.

See:

dolibarr-docker/docker-run.sh

Line 52 in d786523

if [[ ! -f /var/www/html/conf/conf.php ]]; then

---

Even if we were to change this behavior (which I think would be dangerous because we could break existing instances), allowing to update DOLI_INSTANCE_UNIQUE_ID is a no go because we might break encrypted database value and cause data loss for the worst case scenario...

This behavior could be interesting for new instances, but we then need to find a way to prevent regression for existing ones.

Cheers