Skip to content

Commit 7e05c99

Browse files
committed
Test builds without C extensions.
1 parent 3ad4c1c commit 7e05c99

File tree

1 file changed

+25
-13
lines changed

1 file changed

+25
-13
lines changed

.github/workflows/presubmit.yml

Lines changed: 25 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ jobs:
1717
strategy:
1818
matrix:
1919
CMAKE: [3.26.4]
20+
CMAKE_C_EXTENSIONS:
21+
- OFF
22+
- ON
2023
C_COMPILER:
2124
- gcc-11
2225
- gcc-13
@@ -94,6 +97,7 @@ jobs:
9497
-D CMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/external/OpenCL-Headers/install
9598
-D CPACK_PACKAGING_INSTALL_PREFIX=$DEB_INSTALLATION_PATH
9699
-D BUILD_TESTING=OFF
100+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}}
97101
-S $GITHUB_WORKSPACE/external/OpenCL-Headers
98102
-B $GITHUB_WORKSPACE/external/OpenCL-Headers/build &&
99103
$CMAKE_EXE
@@ -111,6 +115,7 @@ jobs:
111115
-G "${{matrix.CONF.GEN}}"
112116
`if [[ "${{matrix.CONF.GEN}}" == "Unix Makefiles" ]]; then echo "-D CMAKE_BUILD_TYPE=${{matrix.CONF.CONFIG}}"; fi`
113117
-D BUILD_TESTING=ON
118+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}}
114119
-D CMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/install
115120
-D CMAKE_PREFIX_PATH=$GITHUB_WORKSPACE/external/OpenCL-Headers/install
116121
-D CPACK_PACKAGING_INSTALL_PREFIX=$DEB_INSTALLATION_PATH
@@ -231,6 +236,9 @@ jobs:
231236
VER: [v142, v143, clangcl]
232237
GEN: [Visual Studio 17 2022, Ninja Multi-Config]
233238
BIN: [x64]
239+
CMAKE_C_EXTENSIONS:
240+
- OFF
241+
- ON
234242
exclude:
235243
- VER: clangcl
236244
GEN: Ninja Multi-Config
@@ -285,7 +293,7 @@ jobs:
285293
-A $BIN `
286294
-T ${{matrix.VER}} `
287295
-D BUILD_TESTING=OFF `
288-
-D CMAKE_C_EXTENSIONS=OFF `
296+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}} `
289297
-D CMAKE_INSTALL_PREFIX=${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\install `
290298
-S ${env:GITHUB_WORKSPACE}\external\OpenCL-Headers `
291299
-B ${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\build
@@ -311,7 +319,7 @@ jobs:
311319
-G "${{matrix.GEN}}" `
312320
-D CMAKE_MAKE_PROGRAM="${env:NINJA_ROOT}\ninja.exe" `
313321
-D BUILD_TESTING=OFF `
314-
-D CMAKE_C_EXTENSIONS=OFF `
322+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}} `
315323
-D CMAKE_INSTALL_PREFIX=${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\install `
316324
-S ${env:GITHUB_WORKSPACE}\external\OpenCL-Headers `
317325
-B ${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\build
@@ -332,7 +340,7 @@ jobs:
332340
-A $BIN `
333341
-T ${{matrix.VER}} `
334342
-D BUILD_TESTING=ON `
335-
-D CMAKE_C_EXTENSIONS=OFF `
343+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}} `
336344
-D CMAKE_INSTALL_PREFIX=${env:GITHUB_WORKSPACE}\install `
337345
-D CMAKE_PREFIX_PATH=${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\install `
338346
-S ${env:GITHUB_WORKSPACE} `
@@ -351,7 +359,7 @@ jobs:
351359
-G "${{matrix.GEN}}" `
352360
-D CMAKE_MAKE_PROGRAM="${env:NINJA_ROOT}\ninja.exe" `
353361
-D BUILD_TESTING=ON `
354-
-D CMAKE_C_EXTENSIONS=OFF `
362+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}} `
355363
-D CMAKE_EXE_LINKER_FLAGS=/INCREMENTAL `
356364
-D CMAKE_INSTALL_PREFIX=${env:GITHUB_WORKSPACE}\install `
357365
-D CMAKE_PREFIX_PATH=${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\install `
@@ -426,7 +434,7 @@ jobs:
426434
-G '${{matrix.GEN}}' `
427435
-A $BIN `
428436
-T ${{matrix.VER}} `
429-
-D CMAKE_C_EXTENSIONS=OFF `
437+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}} `
430438
-D CMAKE_EXE_LINKER_FLAGS=/INCREMENTAL `
431439
-D CMAKE_PREFIX_PATH="${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\install;${env:GITHUB_WORKSPACE}\install" `
432440
-D DRIVER_STUB_PATH="${env:GITHUB_WORKSPACE}\build\Release\OpenCLDriverStub.dll" `
@@ -466,7 +474,7 @@ jobs:
466474
& cmake `
467475
-G '${{matrix.GEN}}' `
468476
-D CMAKE_MAKE_PROGRAM="${env:NINJA_ROOT}\ninja.exe" `
469-
-D CMAKE_C_EXTENSIONS=OFF `
477+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}} `
470478
-D CMAKE_EXE_LINKER_FLAGS=/INCREMENTAL `
471479
-D CMAKE_PREFIX_PATH="${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\install;${env:GITHUB_WORKSPACE}\install" `
472480
-D DRIVER_STUB_PATH="${env:GITHUB_WORKSPACE}\build\Release\OpenCLDriverStub.dll" `
@@ -509,7 +517,7 @@ jobs:
509517
-G '${{matrix.GEN}}' `
510518
-A $BIN `
511519
-T ${{matrix.VER}} `
512-
-D CMAKE_C_EXTENSIONS=OFF `
520+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}} `
513521
-D CMAKE_EXE_LINKER_FLAGS=/INCREMENTAL `
514522
-D CMAKE_PREFIX_PATH="${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\install;${env:GITHUB_WORKSPACE}\install" `
515523
-D DRIVER_STUB_PATH="${env:GITHUB_WORKSPACE}\build\Release\OpenCLDriverStub.dll" `
@@ -549,7 +557,7 @@ jobs:
549557
& cmake `
550558
-G '${{matrix.GEN}}' `
551559
-D CMAKE_MAKE_PROGRAM="${env:NINJA_ROOT}\ninja.exe" `
552-
-D CMAKE_C_EXTENSIONS=OFF `
560+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}} `
553561
-D CMAKE_EXE_LINKER_FLAGS=/INCREMENTAL `
554562
-D CMAKE_PREFIX_PATH="${env:GITHUB_WORKSPACE}\external\OpenCL-Headers\install;${env:GITHUB_WORKSPACE}\install" `
555563
-D DRIVER_STUB_PATH="${env:GITHUB_WORKSPACE}\build\Release\OpenCLDriverStub.dll" `
@@ -592,6 +600,9 @@ jobs:
592600
# - gcc-11
593601
# Disabled due to problems with the __API_AVAILABLE macro
594602
# - gcc-13
603+
CMAKE_C_EXTENSIONS:
604+
- OFF
605+
- ON
595606
GEN:
596607
- Xcode
597608
- Ninja Multi-Config
@@ -626,7 +637,7 @@ jobs:
626637
run: cmake
627638
-G "${{matrix.GEN}}"
628639
-D BUILD_TESTING=OFF
629-
-D CMAKE_C_EXTENSIONS=OFF
640+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}}
630641
-D CMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/external/OpenCL-Headers/install
631642
-S $GITHUB_WORKSPACE/external/OpenCL-Headers
632643
-B $GITHUB_WORKSPACE/external/OpenCL-Headers/build &&
@@ -640,7 +651,7 @@ jobs:
640651
run: cmake
641652
-G "${{matrix.GEN}}"
642653
-D BUILD_TESTING=ON
643-
-D CMAKE_C_EXTENSIONS=OFF
654+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}}
644655
-D CMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/install
645656
-D CMAKE_PREFIX_PATH=$GITHUB_WORKSPACE/external/OpenCL-Headers/install
646657
-S $GITHUB_WORKSPACE
@@ -664,7 +675,7 @@ jobs:
664675
- name: Consume (install)
665676
run: cmake
666677
-G "${{matrix.GEN}}"
667-
-D CMAKE_C_EXTENSIONS=OFF
678+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}}
668679
-D CMAKE_PREFIX_PATH="$GITHUB_WORKSPACE/external/OpenCL-Headers/install;$GITHUB_WORKSPACE/install"
669680
-S $GITHUB_WORKSPACE/test/pkgconfig/bare
670681
-B $GITHUB_WORKSPACE/build_install &&
@@ -681,7 +692,7 @@ jobs:
681692
run: export PKG_CONFIG_PATH=$GITHUB_WORKSPACE/install/lib/pkgconfig:$GITHUB_WORKSPACE/external/OpenCL-Headers/install/share/pkgconfig &&
682693
cmake
683694
-G "${{matrix.GEN}}"
684-
-D CMAKE_C_EXTENSIONS=OFF
695+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}}
685696
-D CMAKE_PREFIX_PATH="$GITHUB_WORKSPACE/external/OpenCL-Headers/install"
686697
-D DRIVER_STUB_PATH=$GITHUB_WORKSPACE/build/Release/libOpenCLDriverStub.dylib
687698
-B $GITHUB_WORKSPACE/build/downstream/pkgconfig
@@ -724,7 +735,7 @@ jobs:
724735
run: cmake
725736
-G "Unix Makefiles"
726737
-D CMAKE_BUILD_TYPE=${{matrix.CONFIG}}
727-
-D CMAKE_C_EXTENSIONS=OFF
738+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}}
728739
-D CMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/external/OpenCL-Headers/install
729740
-D BUILD_TESTING=OFF
730741
-S $GITHUB_WORKSPACE/external/OpenCL-Headers
@@ -739,6 +750,7 @@ jobs:
739750
run: cmake
740751
-G "Unix Makefiles"
741752
-D BUILD_TESTING=ON
753+
-D CMAKE_C_EXTENSIONS=${{matrix.CMAKE_C_EXTENSIONS}}
742754
-D CMAKE_BUILD_TYPE=${{matrix.CONFIG}}
743755
-D CMAKE_TOOLCHAIN_FILE=$ANDROID_NDK/build/cmake/android.toolchain.cmake
744756
-D ANDROID_ABI=${{matrix.ABI}}

0 commit comments

Comments
 (0)