Skip to content

Commit 56e46f0

Browse files
authored
Merge branch 'main' into khr_queue_flush
2 parents dabd10a + 3136aec commit 56e46f0

File tree

43 files changed

+487
-701
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+487
-701
lines changed

CMakeLists.txt

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,6 @@ add_cts_option(SYCL_CTS_ENABLE_EXT_ONEAPI_QUEUE_EMPTY
8888
"Enable extension oneAPI queue_empty tests" OFF
8989
FORCE_ON ${SYCL_CTS_ENABLE_EXT_ONEAPI_TESTS})
9090

91-
add_cts_option(SYCL_CTS_ENABLE_EXT_ONEAPI_DISCARD_QUEUE_EVENTS_TESTS
92-
"Enable extension oneAPI discard_queue_events tests" OFF
93-
FORCE_ON ${SYCL_CTS_ENABLE_EXT_ONEAPI_TESTS})
94-
9591
add_cts_option(SYCL_CTS_ENABLE_EXT_ONEAPI_BFLOAT16_TESTS
9692
"Enable extension oneAPI bfloat16 tests" OFF
9793
FORCE_ON ${SYCL_CTS_ENABLE_EXT_ONEAPI_TESTS})
@@ -148,8 +144,17 @@ add_cts_option(SYCL_CTS_ENABLE_KHR_QUEUE_EMPTY_QUERY_TESTS
148144
"Enable extension Khronos queue_empty_query tests" OFF
149145
FORCE_ON ${SYCL_CTS_ENABLE_KHR_TESTS})
150146

147+
<<<<<<< khr_queue_flush
151148
add_cts_option(SYCL_CTS_ENABLE_KHR_QUEUE_FLUSH_TESTS
152149
"Enable extension Khronos queue_flush tests" OFF
150+
=======
151+
add_cts_option(SYCL_CTS_ENABLE_KHR_MAX_WORK_GROUP_QUERIES_TESTS
152+
"Enable extension Khronos max_work_group_query tests" OFF
153+
FORCE_ON ${SYCL_CTS_ENABLE_KHR_TESTS})
154+
155+
add_cts_option(SYCL_CTS_ENABLE_KHR_WORK_ITEM_QUERIES_TESTS
156+
"Enable extension Khronos work_item_queries tests" OFF
157+
>>>>>>> main
153158
FORCE_ON ${SYCL_CTS_ENABLE_KHR_TESTS})
154159

155160
# TODO: Deprecated - remove
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
:sectnums:
2+
:xrefstyle: short
3+
4+
= Test plan for SYCL extension KHR work item queries
5+
6+
This is a test plan for an extension that defines a new interface for groups
7+
described in
8+
https://github.com/KhronosGroup/SYCL-Docs/blob/f972f91ef7676c1423eb8402974e1682411903eb/adoc/extensions/sycl_khr_work_item_queries.adoc[sycl_khr_work_item_queries].
9+
10+
== Testing scope
11+
12+
=== Device coverage
13+
14+
All of the tests described below are performed only on the default device that
15+
is selected on the CTS command line.
16+
17+
=== Feature test macro
18+
19+
The tests should statically check that the `SYCL_KHR_WORK_ITEM_QUERIES` macro is
20+
defined.
21+
22+
== Tests
23+
24+
The test cases should test the interface of each of the free functions defined
25+
in the extension:
26+
27+
* `sycl::khr::this_nd_item`
28+
* `sycl::khr::this_group`
29+
* `sycl::khr::work_item<sycl::khr::sub_group>`
30+
31+
Each test case should run ND-range kernels with `Dimensions` equal to 1, 2,
32+
and 3.
33+
34+
=== Test description
35+
36+
In the following tests, `Dimensions` is the number of dimensions of the kernel
37+
being tested. Equality checks in the kernels should set a value in a buffer or
38+
USM allocation that is then checked on the host.
39+
40+
==== `sycl::khr::this_nd_item` function
41+
42+
In the kernel scope, the test should call
43+
`sycl::khr::this_nd_item<Dimensions>()` to get an `nd_item<Dimensions>` and
44+
check that it's equal to the one passed as a parameter to the kernel.
45+
46+
==== `sycl::khr::this_group` function
47+
48+
In the kernel scope, the test should call `sycl::khr::this_group<Dimensions>()`
49+
to get an `nd_item<Dimensions>` and check that it's equal to the one obtained
50+
from the kernel's `nd_item` using the `nd_item::get_group` member function.
51+
52+
==== `sycl::khr::this_sub_group` class
53+
54+
In the kernel scope, the test should use function to get a `sub_group` and check
55+
that it's equal to the one obtained from the kernel's `nd_item` using the
56+
`nd_item::get_sub_group` member function.
57+

test_plans/oneapi/discard_queue_events.asciidoc

Lines changed: 0 additions & 103 deletions
This file was deleted.

tests/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ endfunction()
6868
function(get_no_vec_alias_type OUT_LIST)
6969
set(NO_VEC_ALIAS_LIST "")
7070
list(APPEND NO_VEC_ALIAS_LIST sycl::byte)
71+
list(APPEND NO_VEC_ALIAS_LIST std::byte)
7172

7273
set(${OUT_LIST} ${${OUT_LIST}} ${NO_VEC_ALIAS_LIST} PARENT_SCOPE)
7374
endfunction()

tests/accessor_legacy/accessor_api_local_common.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,8 +328,8 @@ struct check_local_accessor_api_dim<generic_path_t> {
328328
// Do not run atomic64 checks
329329
#if SYCL_CTS_ENABLE_VERBOSE_LOG
330330
constexpr auto mode = sycl::access_mode::atomic;
331-
log_accessor<T, kernelName, dims, mode, target>(
332-
"skip_local_accessor_atomic64", typeName, log);
331+
log_accessor<T, dims, mode, target>("skip_local_accessor_atomic64",
332+
typeName, log);
333333
#else
334334
static_cast<void>(log);
335335
static_cast<void>(typeName);

tests/address_space/address_space_fp16.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#define TEST_NAME address_space_fp16
1010

1111
#include "../common/common.h"
12-
#include "./../../util/extensions.h"
1312
#include "address_space_common.h"
1413

1514
namespace TEST_NAMESPACE {
@@ -24,9 +23,12 @@ class TEST_NAME : public sycl_cts::util::test_base {
2423
void run(util::logger &log) override {
2524
auto queue = util::get_cts_object::queue();
2625

27-
using availability =
28-
util::extensions::availability<util::extensions::tag::fp16>;
29-
if (!availability::check(queue, log)) return;
26+
if (!queue.get_device().has(sycl::aspect::fp16)) {
27+
WARN(
28+
"Device doesn't support half precision floating point data type - "
29+
"skipping the test");
30+
return;
31+
}
3032

3133
test_types<sycl::half>(log);
3234
}

tests/address_space/address_space_fp64.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#define TEST_NAME address_space_fp64
1010

1111
#include "../common/common.h"
12-
#include "./../../util/extensions.h"
1312
#include "address_space_common.h"
1413

1514
namespace TEST_NAMESPACE {
@@ -24,9 +23,12 @@ class TEST_NAME : public sycl_cts::util::test_base {
2423
void run(util::logger &log) override {
2524
auto queue = util::get_cts_object::queue();
2625

27-
using availability =
28-
util::extensions::availability<util::extensions::tag::fp64>;
29-
if (!availability::check(queue, log)) return;
26+
if (!queue.get_device().has(sycl::aspect::fp64)) {
27+
WARN(
28+
"Device doesn't support double precision floating point data type - "
29+
"skipping the test");
30+
return;
31+
}
3032

3133
test_types<double>(log);
3234
}

0 commit comments

Comments
 (0)