-
Notifications
You must be signed in to change notification settings - Fork 30
Open
Labels
CoreIssues related to Axom's 'core' componentIssues related to Axom's 'core' componentGPUIssues related to GPU developmentIssues related to GPU developmentReviewedenhancementNew feature or requestNew feature or request
Description
When working on #1646, one issue I discovered was passing axom::Array::begin()
and axom::Array::end()
to FlatMap::insert
resulted in memory errors on CUDA/HIP. This is because the current implementation takes a pointer to axom::Array
:
axom/src/axom/core/ArrayIteratorBase.hpp
Lines 40 to 41 in 915db00
public: | |
using ArrayPointerType = ArrayType*; |
axom/src/axom/core/ArrayIteratorBase.hpp
Line 60 in 915db00
ArrayPointerType m_arrayPtr {nullptr}; |
If the Array
instance is allocated on the stack, i.e. any Array
variable defined in a function, this results in an access to host-only memory. We should evaluate if it would be more appropriate to store an ArrayView
as the "pointer."
Metadata
Metadata
Assignees
Labels
CoreIssues related to Axom's 'core' componentIssues related to Axom's 'core' componentGPUIssues related to GPU developmentIssues related to GPU developmentReviewedenhancementNew feature or requestNew feature or request