-
Notifications
You must be signed in to change notification settings - Fork 30
Open
Labels
PerformanceIssues related to code performanceIssues related to code performanceSlicIssues related to Axom's 'slic' componentIssues related to Axom's 'slic' component
Description
We might want to add a counter to GenericOutputStream
to indicate if any messages have been logged since the last flush()
and only call flush()
when there are messages. Flushing w/ no messages might be expensive since it might need to open and append (nothing) to a file.
See:
axom/src/axom/slic/streams/GenericOutputStream.cpp
Lines 127 to 138 in 25744e5
void GenericOutputStream::outputLocal() | |
{ | |
openBeforeFlush(); | |
m_stream->flush(); | |
} | |
//------------------------------------------------------------------------------ | |
void GenericOutputStream::flush() | |
{ | |
openBeforeFlush(); | |
m_stream->flush(); | |
} |
Originally posted by @kennyweiss in #1649 (comment)
kennyweiss
Metadata
Metadata
Assignees
Labels
PerformanceIssues related to code performanceIssues related to code performanceSlicIssues related to Axom's 'slic' componentIssues related to Axom's 'slic' component