Skip to content

Positive timer offsets can panic #820

Closed
@CryZe

Description

@CryZe

Instant is usually internally an unsigned integer. Subtracting the timer offset from it for the ActiveAttempt::start_time_with_offset, can result in the value underflowing and panicking. We should refactor the active attempt code to not subtract from the Instant / TimeStamp. We also for sure need a test for this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugThere is a bug.priority: highThis is a high priority issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions