Single Role: replace flatten with lookup(flattened

In stable-2.19, flatten keeps the list markings []

Various comment and typo changes.

In the *ignore files, change ignore more combinations of .swp files
(**.sw[nop]). And switch remote_hosts.yml to just rhosts.yml.

Author: Bill Meek

.dockerignore

@@ -6,11 +6,10 @@
 .yamllint.yml
 *.sh
 *.setup.out
-**.swo
-**.swp
+**.sw[nop]
 *~
 **/Docker
 Dockerfile
 README.md
-remote_hosts.yml
+rhosts.yml
 tags

.gitignore

@@ -4,12 +4,11 @@ Dockerfile
 Docker
 group_vars/user_options.yml
 tags
-remote_hosts.yml
+rhosts.yml
 *~
 *.setup.out
 *.sh
-**.swo
-**.swp
+**.sw[nop]
 # If retry_files_enabled=False gets changed in ansible.cfg
 mythtv.retry
 qt5.retry

hosts.yml

@@ -20,7 +20,7 @@ mythtv_hosts:
       ansible_python_interpreter: /usr/libexec/platform-python
     f30:
       ansible_python_interpreter: /usr/bin/python3
-    freebsd:
+    freebsd:  # If sudo isn't installed on the host
       ansible_become_method: su
       use_old_roles: false
     macosx:

roles/common/tasks/main.yml

@@ -2,6 +2,10 @@
 # prevent users from running ALL hosts. The instructions are clear that
 # the --limit=<name> must be used. The debug: prints information useful
 # for diagnosing issues.
+#
+# Next, print some valuable debugging information
+#
+# Finally, load any user specific variables (not under git control).
 
 ---
 

roles/mythtv-deb/tasks/debian.yml

@@ -175,7 +175,6 @@
   block:
     - set_fact:
         deb_pkg_lst: '{{ lookup("flattened", deb_pkg_lst) }}'
-        # deb_pkg_lst: '{{ deb_pkg_lst | flatten() }}'
 
     - set_fact:
         deb_pkg_lst: "{{ deb_pkg_lst | replace('python3-oauth', 'python3-oauthlib') }}"

roles/mythtv-pacman/tasks/yay.yml

@@ -75,7 +75,6 @@
 - name: yay | '{{ manual_action_text }}'
   debug:
     msg: 'yay -S {{ lookup("flattened", aur_packages) | regex_replace(",", " ") }}'
-    # msg: 'yay -S {{ list_o_strings | flatten() | regex_replace(",", " ") }}'
 
 ...
 

roles/mythtv/tasks/main.yml

@@ -62,11 +62,11 @@
 
 - name: Flatten package lists
   set_fact:
-    packages: '{{ packages | flatten() | sort }}'
+    packages: '{{ lookup("flattened", packages) }}'
 
 - name: Final package list
   debug:
-    msg: '{{ packages }}'
+    var: packages
 
 - name: Install the packages
   package:

roles/mythtv/tasks/pacman_archlinux.yml

@@ -75,7 +75,6 @@
 - name: pacman_archlinux | '{{ manual_action_text }}'
   debug:
     msg: 'yay -S {{ lookup("flattened", aur_packages) | regex_replace(",", " ") }}'
-    # msg: 'yay -S {{ list_o_strings | flatten() | regex_replace(",", " ") }}'
 
 ...