Credentials not saved to database when using SMB

[seihtam]

Describe the bug
Credentials are not saved to database when using SMB.

To Reproduce
Login with SMB: nxc smb DC.voleur.htb -u 'ryan.naylor' -p 'HollowOct31Nyt' -k

See that there are no credentials saved in the database: sqlite3 "$HOME/.nxc/workspaces/default/smb.db" 'SELECT * FROM users'

When running the same command with LDAP then credentials are saved as expected.

Expected behavior
Credentials should be saved to the database when authenticating over SMB.

Screenshots

NetExec info

• OS: Kali
• Version of nxc: 1.5.0 - Yippie-Ki-Yay - f363124 - 67
• Installed from: pipx

[NeffIsBack]

Hi, yes this is also true for the SMB protocol. I think this was a design decision at some point because there are so many ways that false positives could be added (delegation for example) or simply no cred type being available (TGTs/STs). We could do something like in the LDAP protocol and add them if either nt hash or password is available, but we would still have the problem of false positives.