Skip to content

Commit b4f2825

Browse files
authored
Merge pull request #97 from sauagarwa/fix-upload-pdf
Removed the commends in the upload pdf task, it was failing on Mac
2 parents 18ee875 + 5a77fab commit b4f2825

File tree

5 files changed

+2
-4
lines changed

5 files changed

+2
-4
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,4 +178,5 @@ cython_debug/
178178
*.pyc
179179
deploy/helm/namespace
180180
deploy/helm/secrets
181-
uv.lock
181+
uv.lock
182+
.DS_Store

deploy/helm/Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,14 +164,11 @@ upload-pdf:
164164
@find $(PDF_DIR) -name "*.pdf" -type f | while read -r pdf_file; do \
165165
echo "Uploading $${pdf_file}..."; \
166166
test -f "$${pdf_file}" || { echo "Error: File $${pdf_file} not found"; continue; }; \
167-
# Create a safe unique temporary filename using a timestamp and counter to prevent issues with special chars\
168167
temp_name="tmp_$$(date +%s)_$${RANDOM}.pdf"; \
169168
echo "Creating temporary file in minio pod with safe name: $${temp_name}"; \
170169
cat "$${pdf_file}" | oc exec -i -n $(NAMESPACE) minio-0 -- bash -c "cat > /tmp/$${temp_name}"; \
171-
# Extract original filename \
172170
orig_name="$$(basename "$${pdf_file}")"; \
173171
echo "Uploading file to bucket with original name: $${orig_name}"; \
174-
# Copying file with temporary name, then renaming it to original name \
175172
oc exec -n $(NAMESPACE) minio-0 -- bash -c "mc cp /tmp/$${temp_name} local/$(BUCKET_NAME)/$${temp_name} && \
176173
mc mv local/$(BUCKET_NAME)/$${temp_name} \"local/$(BUCKET_NAME)/$${orig_name}\" && \
177174
rm /tmp/$${temp_name}"; \

0 commit comments

Comments
 (0)