[tbb/omp] Removing/deactivating OMP threading support since we would still have a TBB dependency

Author: sherholz-intel

CHANGELOG.md

@@ -24,6 +24,8 @@ Version History
         - Adding `ClearSurface` and `ClearVolume` function to clear the surface and volume samples separately.
           This allows to wait until a specific number of samples is collected for the surface or volume cache before updating/fitting the `Field`.
 
+- Deactivating/removing `OMP` threading support since it would still have a dependency on `TBB`
+
 - Bugfixes:
     - Fixing bug causing crash during `Field::Update` when in previous iterations no volume or surface samples were present.
 

CMakeLists.txt

@@ -29,7 +29,7 @@ include(openpgl_macros)
 
 ## openpgl specific configuration ##
 
-option(OPENPGL_USE_OMP_THREADING "Use omp instead of tbb for threading." OFF)
+#option(OPENPGL_USE_OMP_THREADING "Use omp instead of tbb for threading." OFF)
 option(OPENPGL_BUILD_STATIC "Build OpenPGL as static library." OFF)
 
 option(OPENPGL_BUILD_TOOLS "Build tool applications." OFF)

README.md

@@ -51,6 +51,7 @@ specification is still in flux and might change with upcoming releases.
 ## Open PGL 0.5.0
 
   - Api changes:
+    
       - `PathSegmentStorage`:
           - Removed support for splatting training samples due to the
             fact that knn-lookups have proven to be better. Therefore,
@@ -75,7 +76,12 @@ specification is still in flux and might change with upcoming releases.
             the surface and volume samples separately. This allows to
             wait until a specific number of samples is collected for the
             surface or volume cache before updating/fitting the `Field`.
+
+  - Deactivating/removing `OMP` threading support since it would still
+    have a dependency on `TBB`
+
   - Bugfixes:
+    
       - Fixing bug causing crash during `Field::Update` when in previous
         iterations no volume or surface samples were present.
 

openpgl/CMakeLists.txt

@@ -110,18 +110,18 @@ else()
 endif()
 
 
-if(OPENPGL_USE_OMP_THREADING)
-  set(OPENPGL_RELEASE_OPTIONS -fopenmp)
-endif()
+#if(OPENPGL_USE_OMP_THREADING)
+#  set(OPENPGL_RELEASE_OPTIONS -fopenmp)
+#endif()
 
 target_compile_options(${PROJECT_NAME} PUBLIC "$<$<CONFIG:RELEASE>:${OPENPGL_RELEASE_OPTIONS}>")
 
 # CMAKE 3.8 feature
 #target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_11)
 
-if(OPENPGL_USE_OMP_THREADING)
-  add_compile_definitions(OPENPGL_USE_OMP_THREADING)
-endif()
+#if(OPENPGL_USE_OMP_THREADING)
+#  add_compile_definitions(OPENPGL_USE_OMP_THREADING)
+#endif()
 
 #add_compile_options()