24 prevent nonstatic class (#36)

* Reuse code via simlink between it java8 and java17

* Report error for non-static inner class

Author: cuzfrog

doc/Development.md

@@ -1,7 +1,7 @@
 # Development Guide
 
 ## Setup
-Linux is recommended. If you use Windows, you can use WSL with a remotely connected IDE. Windows 11 supports GUI app inside WSL.
+**Linux is assumed**. If you use Windows, you can use WSL with a remotely connected IDE. Windows 11 supports GUI app inside WSL.
 
 Setup Java env vars (>= Java17 for development), configure `JAVA17_HOME` to point to your Java installation:
 ```bash

doc/Usage.md

@@ -86,3 +86,5 @@ See Javadoc on [@SharedType](../annotation/src/main/java/org/sharedtype/annotati
 * Current design only retain `@SharedType` on source level. That means they are not visible if it is in a dependency jar during its dependent's compilation.
 You have to execute the annotation processing on the same classpath with source code.
 For multiple module builds, a workaround is to execute on every module.
+* Non-static inner classes are not supported. Instance class may refer to its enclosing class's generic type without the type declaration on its own,
+which could break the generated code. Later version of SharedType may loosen this limitation.

it/java17/src/main/java/org/sharedtype/it/types/JavaRecord.java renamed to it/java17/src/main/java/org/sharedtype/it/java17/JavaRecord.java

@@ -1,6 +1,11 @@
-package org.sharedtype.it.types;
+package org.sharedtype.it.java17;
 
 import org.sharedtype.annotation.SharedType;
+import org.sharedtype.it.java8.Container;
+import org.sharedtype.it.java8.DependencyClassA;
+import org.sharedtype.it.java8.EnumGalaxy;
+import org.sharedtype.it.java8.EnumSize;
+import org.sharedtype.it.java8.InterfaceA;
 
 import java.util.Collection;
 import java.util.List;

it/java17/src/main/java/org/sharedtype/it/java8

@@ -0,0 +1 @@
+../../../../../../../java8/src/main/java/org/sharedtype/it/java8

it/java17/src/main/java/org/sharedtype/it/java8_is_symlink

@@ -1,10 +1,13 @@
-package org.sharedtype.domain;
+package org.sharedtype.it;
 
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInstance;
+import org.sharedtype.domain.ArrayTypeInfo;
+import org.sharedtype.domain.ClassDef;
+import org.sharedtype.domain.ConcreteTypeInfo;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.sharedtype.domain.TypeDefDeserializer.deserializeTypeDef;
+import static org.sharedtype.it.TypeDefDeserializer.deserializeTypeDef;
 
 @TestInstance(TestInstance.Lifecycle.PER_CLASS)
 final class JavaRecordIntegrationTest {
@@ -25,7 +28,7 @@ void supertypes() {
         assertThat(superTypes).hasSize(1);
         var supertypeInfo = (ConcreteTypeInfo)superTypes.get(0);
         assertThat(supertypeInfo.resolved()).isTrue();
-        assertThat(supertypeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.types.InterfaceA");
+        assertThat(supertypeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.java8.InterfaceA");
     }
 
     @Test
@@ -185,7 +188,7 @@ void cyclicDependencyField() {
         var cyclicDependencyField = classDef.components().get(19);
         assertThat(cyclicDependencyField.name()).isEqualTo("cyclicDependency");
         var typeInfo = (ConcreteTypeInfo)cyclicDependencyField.type();
-        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.types.DependencyClassA");
+        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.java8.DependencyClassA");
     }
 
     @Test
@@ -194,7 +197,7 @@ void containerStringListField() {
         assertThat(containerStringListField.name()).isEqualTo("containerStringList");
         var arrayTypeInfo = (ArrayTypeInfo)containerStringListField.type();
         var typeInfo = (ConcreteTypeInfo)arrayTypeInfo.component();
-        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.types.Container");
+        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.java8.Container");
         var typeArgInfo = (ConcreteTypeInfo)typeInfo.typeArgs().get(0);
         assertThat(typeArgInfo.qualifiedName()).isEqualTo("java.lang.String");
     }
@@ -206,7 +209,7 @@ void containerStringListCollectionField() {
         var arrayTypeInfo = (ArrayTypeInfo)containerStringListCollectionField.type();
         var nestedArrayTypeInfo = (ArrayTypeInfo)arrayTypeInfo.component();
         var typeInfo = (ConcreteTypeInfo)nestedArrayTypeInfo.component();
-        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.types.Container");
+        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.java8.Container");
         var typeArgInfo = (ConcreteTypeInfo)typeInfo.typeArgs().get(0);
         assertThat(typeArgInfo.qualifiedName()).isEqualTo("java.lang.String");
     }
@@ -267,15 +270,15 @@ void enumGalaxyField() {
         var enumGalaxyField = classDef.components().get(28);
         assertThat(enumGalaxyField.name()).isEqualTo("enumGalaxy");
         var typeInfo = (ConcreteTypeInfo)enumGalaxyField.type();
-        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.types.EnumGalaxy");
+        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.java8.EnumGalaxy");
     }
 
     @Test
     void enumSizeField() {
         var enumSizeField = classDef.components().get(29);
         assertThat(enumSizeField.name()).isEqualTo("enumSize");
         var typeInfo = (ConcreteTypeInfo)enumSizeField.type();
-        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.types.EnumSize");
+        assertThat(typeInfo.qualifiedName()).isEqualTo("org.sharedtype.it.java8.EnumSize");
     }
 
     @Test

it/java17/src/main/java/org/sharedtype/it/types/SuperClassA.java

@@ -1,121 +1,126 @@
-package org.sharedtype.domain;
+package org.sharedtype.it;
 
+import lombok.val;
 import org.assertj.core.api.SoftAssertions;
 import org.junit.jupiter.api.Test;
+import org.sharedtype.domain.ClassDef;
+import org.sharedtype.domain.ConcreteTypeInfo;
+import org.sharedtype.domain.EnumDef;
+import org.sharedtype.domain.TypeVariableInfo;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.sharedtype.domain.TypeDefDeserializer.deserializeTypeDef;
+import static org.sharedtype.it.TypeDefDeserializer.deserializeTypeDef;
 
 final class TypeDefIntegrationTest {
     @Test
     void container() {
-        var container = (ClassDef) deserializeTypeDef("Container.ser");
+        ClassDef container = (ClassDef) deserializeTypeDef("Container.ser");
         SoftAssertions.assertSoftly(softly -> {
             softly.assertThat(container.simpleName()).isEqualTo("Container");
-            softly.assertThat(container.qualifiedName()).isEqualTo("org.sharedtype.it.types.Container");
+            softly.assertThat(container.qualifiedName()).isEqualTo("org.sharedtype.it.java8.Container");
             softly.assertThat(container.components()).hasSize(1);
-            var component1 = container.components().get(0);
-            var field1Type = (TypeVariableInfo) component1.type();
+            val component1 = container.components().get(0);
+            val field1Type = (TypeVariableInfo) component1.type();
             softly.assertThat(field1Type.getName()).isEqualTo("T");
             softly.assertThat(component1.name()).isEqualTo("t");
 
             softly.assertThat(container.resolved()).isTrue();
             softly.assertThat(container.typeVariables()).hasSize(1);
-            var typeVariable1 = container.typeVariables().get(0);
+            val typeVariable1 = container.typeVariables().get(0);
             softly.assertThat(typeVariable1.getName()).isEqualTo("T");
         });
     }
 
     @Test
     void dependencyClassA() {
-        var classA = (ClassDef) deserializeTypeDef("DependencyClassA.ser");
+        ClassDef classA = (ClassDef) deserializeTypeDef("DependencyClassA.ser");
         SoftAssertions.assertSoftly(softly -> {
             softly.assertThat(classA.simpleName()).isEqualTo("DependencyClassA");
-            softly.assertThat(classA.qualifiedName()).isEqualTo("org.sharedtype.it.types.DependencyClassA");
+            softly.assertThat(classA.qualifiedName()).isEqualTo("org.sharedtype.it.java8.DependencyClassA");
             softly.assertThat(classA.components()).hasSize(1);
 
-            var component1 = classA.components().get(0);
+            val component1 = classA.components().get(0);
             softly.assertThat(component1.optional()).isFalse();
             softly.assertThat(component1.name()).isEqualTo("b");
             softly.assertThat(component1.type().resolved()).isTrue();
-            var component1type = (ConcreteTypeInfo) component1.type();
-            softly.assertThat(component1type.qualifiedName()).isEqualTo("org.sharedtype.it.types.DependencyClassB");
+            val component1type = (ConcreteTypeInfo) component1.type();
+            softly.assertThat(component1type.qualifiedName()).isEqualTo("org.sharedtype.it.java8.DependencyClassB");
 
             softly.assertThat(classA.typeVariables()).isEmpty();
             softly.assertThat(classA.supertypes()).hasSize(1);
-            var supertype1 = (ConcreteTypeInfo)classA.supertypes().get(0);
+            val supertype1 = (ConcreteTypeInfo)classA.supertypes().get(0);
             softly.assertThat(supertype1.resolved()).isTrue();
-            softly.assertThat(supertype1.qualifiedName()).isEqualTo("org.sharedtype.it.types.SuperClassA");
+            softly.assertThat(supertype1.qualifiedName()).isEqualTo("org.sharedtype.it.java8.SuperClassA");
             softly.assertThat(classA.resolved()).isTrue();
         });
     }
 
     @Test
     void dependencyClassB() {
-        var classB = (ClassDef) deserializeTypeDef("DependencyClassB.ser");
+        ClassDef classB = (ClassDef) deserializeTypeDef("DependencyClassB.ser");
         assertThat(classB.simpleName()).isEqualTo("DependencyClassB");
     }
 
     @Test
     void dependencyClassC() {
-        var classC = (ClassDef) deserializeTypeDef("DependencyClassC.ser");
+        ClassDef classC = (ClassDef) deserializeTypeDef("DependencyClassC.ser");
         assertThat(classC.simpleName()).isEqualTo("DependencyClassC");
     }
 
     @Test
     void enumGalaxy() {
-        var enumGalaxy = (EnumDef) deserializeTypeDef("EnumGalaxy.ser");
+        EnumDef enumGalaxy = (EnumDef) deserializeTypeDef("EnumGalaxy.ser");
         assertThat(enumGalaxy.simpleName()).isEqualTo("EnumGalaxy");
-        assertThat(enumGalaxy.qualifiedName()).isEqualTo("org.sharedtype.it.types.EnumGalaxy");
+        assertThat(enumGalaxy.qualifiedName()).isEqualTo("org.sharedtype.it.java8.EnumGalaxy");
         assertThat(enumGalaxy.components()).hasSize(3).allMatch(constant -> {
-            var typeInfo = (ConcreteTypeInfo)constant.type();
+            ConcreteTypeInfo typeInfo = (ConcreteTypeInfo)constant.type();
             return typeInfo.qualifiedName().equals("java.lang.String");
         });
-        var constant1 = enumGalaxy.components().get(0);
+        val constant1 = enumGalaxy.components().get(0);
         assertThat(constant1.value()).isEqualTo("MilkyWay");
 
-        var constant2 = enumGalaxy.components().get(1);
+        val constant2 = enumGalaxy.components().get(1);
         assertThat(constant2.value()).isEqualTo("Andromeda");
 
-        var constant3 = enumGalaxy.components().get(2);
+        val constant3 = enumGalaxy.components().get(2);
         assertThat(constant3.value()).isEqualTo("Triangulum");
     }
 
     @Test
     void enumSize() {
-        var enumSize = (EnumDef) deserializeTypeDef("EnumSize.ser");
+        EnumDef enumSize = (EnumDef) deserializeTypeDef("EnumSize.ser");
         assertThat(enumSize.simpleName()).isEqualTo("EnumSize");
-        assertThat(enumSize.qualifiedName()).isEqualTo("org.sharedtype.it.types.EnumSize");
+        assertThat(enumSize.qualifiedName()).isEqualTo("org.sharedtype.it.java8.EnumSize");
         assertThat(enumSize.components()).hasSize(3).allMatch(constant -> {
-            var typeInfo = (ConcreteTypeInfo)constant.type();
+            ConcreteTypeInfo typeInfo = (ConcreteTypeInfo)constant.type();
             return typeInfo.qualifiedName().equals("int");
         });
 
-        var constant1 = enumSize.components().get(0);
+        val constant1 = enumSize.components().get(0);
         assertThat(constant1.value()).isEqualTo(1);
 
-        var constant2 = enumSize.components().get(1);
+        val constant2 = enumSize.components().get(1);
         assertThat(constant2.value()).isEqualTo(2);
 
-        var constant3 = enumSize.components().get(2);
+        val constant3 = enumSize.components().get(2);
         assertThat(constant3.value()).isEqualTo(3);
     }
 
     @Test
     void interfaceA() {
-        var interfaceA = (ClassDef) deserializeTypeDef("InterfaceA.ser");
+        ClassDef interfaceA = (ClassDef) deserializeTypeDef("InterfaceA.ser");
         assertThat(interfaceA.simpleName()).isEqualTo("InterfaceA");
     }
 
     @Test
     void superClassA() {
-        var superClassA = (ClassDef) deserializeTypeDef("SuperClassA.ser");
+        ClassDef superClassA = (ClassDef) deserializeTypeDef("SuperClassA.ser");
         SoftAssertions.assertSoftly(softly -> {
             softly.assertThat(superClassA.simpleName()).isEqualTo("SuperClassA");
             softly.assertThat(superClassA.components()).hasSize(1);
-            var component1 = superClassA.components().get(0);
+            val component1 = superClassA.components().get(0);
             softly.assertThat(component1.name()).isEqualTo("a");
-            var component1type = (ConcreteTypeInfo) component1.type();
+            val component1type = (ConcreteTypeInfo) component1.type();
             softly.assertThat(component1type.qualifiedName()).isEqualTo("int");
         });
     }

it/java17/src/test/java/org/sharedtype/domain/JavaRecordIntegrationTest.java renamed to it/java17/src/test/java/org/sharedtype/it/JavaRecordIntegrationTest.java

@@ -1,10 +1,10 @@
-package org.sharedtype.it.types;
+package org.sharedtype.it.java8;
 
 import lombok.Getter;
 import lombok.Setter;
 
 @Getter
 @Setter
-final class Container<T> {
+public final class Container<T> {
     private T t;
 }

it/java17/src/test/java/org/sharedtype/domain/TypeDefIntegrationTest.java renamed to it/java17/src/test/java/org/sharedtype/it/TypeDefIntegrationTest.java

@@ -1,8 +1,8 @@
-package org.sharedtype.it.types;
+package org.sharedtype.it.java8;
 
 import lombok.RequiredArgsConstructor;
 
 @RequiredArgsConstructor
-final class DependencyClassA extends SuperClassA{
+public final class DependencyClassA extends SuperClassA{
     private final DependencyClassB b;
 }