wip - PR feedback

Author: PatrickDinh

MIGRATION-NOTES.md

@@ -36,3 +36,4 @@ A collection of random notes pop up during the migration process.
 - ABI
   - how to construct ABIStruct from string
 - Make sure that the python utils also sort resources during resource population
+- migration stratefy for EventType.TxnGroupSimulated in utils-ts-debug

src/transactions/common.ts

@@ -3,8 +3,7 @@ import { Address, TransactionSigner } from '@algorandfoundation/sdk'
 import { encodeLease } from '../transaction'
 import { TransactionSignerAccount } from '../types/account'
 import { AlgoAmount } from '../types/amount'
-import { FeeDelta } from '../types/fee-coverage'
-import { genesisIdIsLocalNet } from '../types/network-client'
+import { FeeDelta } from './fee-coverage'
 
 /** Common parameters for defining a transaction. */
 export type CommonTransactionParams = {
@@ -69,7 +68,7 @@ export const ensureString = (data?: string | Uint8Array) => {
 export const buildTransactionHeader = (
   commonParams: CommonTransactionParams,
   suggestedParams: SuggestedParams,
-  defaultValidityWindow: number,
+  defaultValidityWindow: bigint,
 ) => {
   const firstValid = commonParams.firstValidRound ?? suggestedParams.firstValid
   const lease = commonParams.lease === undefined ? undefined : encodeLease(commonParams.lease)
@@ -86,9 +85,7 @@ export const buildTransactionHeader = (
     firstValid,
     lastValid:
       commonParams.lastValidRound ??
-      (commonParams.validityWindow !== undefined
-        ? firstValid + BigInt(commonParams.validityWindow)
-        : firstValid + BigInt(defaultValidityWindow)),
+      (commonParams.validityWindow !== undefined ? firstValid + BigInt(commonParams.validityWindow) : firstValid + defaultValidityWindow),
     group: undefined,
   } satisfies TransactionHeader
 }
@@ -124,12 +121,3 @@ export function calculateInnerFeeDelta(
     return currentFeeDelta
   }, acc)
 }
-
-export function getDefaultValidityWindow(genesisId: string): number {
-  const isLocalNet = genesisIdIsLocalNet(genesisId)
-  if (isLocalNet) {
-    return 1000 // LocalNet gets bigger window to avoid dead transactions
-  } else {
-    return 10 // Standard default validity window
-  }
-}