Skip to content

Commit 3b4fbac

Browse files
author
Aliaksandr.Shpak
committed
- A number of fixes
1 parent 40ec868 commit 3b4fbac

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

src/main/scala/devtools/lib/rxui/FxRender.scala

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
package devtools.lib.rxui
22

3+
import java.util.UUID
34
import java.util.UUID
45
import java.util.concurrent.TimeUnit
56
import scala.collection.JavaConverters._
67
import scala.collection.mutable
78
import scala.language.{implicitConversions, postfixOps}
89

9-
import com.sun.javafx.application.LauncherImpl
1010
import io.reactivex.Scheduler
1111
import io.reactivex.Scheduler.Worker
1212
import io.reactivex.disposables.Disposable
13-
import javafx.application.{Application, Platform}
13+
import javafx.application.Platform
1414
import javafx.beans.property.{Property, SimpleStringProperty}
1515
import javafx.beans.value.{ChangeListener, ObservableValue}
1616
import javafx.collections.{ListChangeListener, ObservableList}
@@ -26,7 +26,6 @@ import javafx.stage.{Modality, Stage, StageStyle}
2626

2727
import devtools.lib.rxext.ListChangeOps.{AddItems, InsertItems, RemoveItemObjs, RemoveItems, SetList}
2828
import devtools.lib.rxext.{Observable, Subject}
29-
import devtools.lib.rxui.FxRender.primaryStage
3029

3130
object FxRender {
3231

@@ -135,7 +134,7 @@ object FxRender {
135134
}
136135

137136
class UiListRenderer[T](list: UiList[T]) extends ObservingRenderer[ListView[T]] {
138-
private val $row$ = new DisposeStore()
137+
private val $rows$ = new DisposeStore()
139138
private val $menu$ = new DisposeStore()
140139

141140
override def render(): ListView[T] = {
@@ -148,13 +147,13 @@ object FxRender {
148147
override def updateItem(item: T, empty: Boolean): Unit = {
149148
super.updateItem(item, empty)
150149
if (!empty && item != null) {
151-
for (text <- $row$(list.valueProvider(item))) setText(text) /// TODO INCORRECT YET, MUST DISPOSE ONE ROW
150+
for (text <- $rows$(list.valueProvider(item))) setText(text)
152151
} else setText(null)
153152
}
154153
}
155154
})
156155
for (items <- $(list.items)) {
157-
$row$.dispose()
156+
$rows$.dispose()
158157
c.getItems.clear()
159158
c.getItems.addAll(items.asJava)
160159
}
@@ -188,7 +187,7 @@ object FxRender {
188187
}
189188

190189
override def dispose(): Unit = {
191-
$row$.dispose()
190+
$rows$.dispose()
192191
$menu$.dispose()
193192
super.dispose()
194193
}

0 commit comments

Comments
 (0)