Skip to content

Commit 4924fa9

Browse files
authored
Add to cache read failure log 'falling back to S3' (#1245)
When a cache read fails, there have been open questions in support cases about if that will have then failed the whole read or asked S3. This is a simple change to address that ambiguity. ### Does this change impact existing behavior? Simple logging change only. ### Does this change need a changelog entry? Does it require a version change? No, simple log content change. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Daniel Carl Jones <[email protected]>
1 parent 2089a3b commit 4924fa9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mountpoint-s3/src/prefetch/caching_stream.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ where
170170
block_index,
171171
?range,
172172
?error,
173-
"error reading block from cache",
173+
"error reading block from cache, falling back to S3",
174174
),
175175
}
176176
// If a block is uncached or reading it fails, fallback to S3 for the rest of the stream.

0 commit comments

Comments
 (0)