Split up client and fs integration tests in CI (#1523)

Organize the integration test workflows in two groups:

1. Client tests, for the `mountpoint-s3-client` crate (and its
dependencies: `mountpoint-s3-crt` and `mountpoint-s3-crt-sys`)
2. FS tests, for `mountpoint-s3-fs` and `mountpoint-s3`

Both groups define a matrix strategy across runners and S3 buckets.
Additionally, the first group adds a dimension for the memory pool
(currently default and test pool), while the second runs tests with FUSE
2 and 3.

### Does this change impact existing behavior?

No, CI change only.

### Does this change need a changelog entry? Does it require a version
change?

No.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

---------

Signed-off-by: Alessandro Passaro <alexpax@amazon.co.uk>

Author: passaro

.github/workflows/integration.yml

@@ -37,84 +37,39 @@ env:
   S3_EXPRESS_ONE_ZONE_BUCKET_NAME_EXTERNAL: ${{ vars.S3_EXPRESS_ONE_ZONE_BUCKET_NAME_EXTERNAL }}
   KMS_TEST_KEY_ID: ${{ vars.KMS_TEST_KEY_ID }}
   S3_EXPRESS_ONE_ZONE_BUCKET_NAME_SSE_KMS: ${{ vars.S3_EXPRESS_ONE_ZONE_BUCKET_NAME_SSE_KMS }}
-  RUST_FEATURES: fuse_tests,s3_tests,fips_tests,event_log,second_account_tests,manifest
 
 permissions:
   id-token: write
   contents: read
 
 jobs:
   test:
-    name: Tests (${{ matrix.runner.name }}, FUSE ${{ matrix.fuseVersion }})
-    runs-on: ${{ matrix.runner.tags }}
-
-    environment: ${{ inputs.environment }}
-
-    strategy:
-      fail-fast: false
-      matrix:
-        fuseVersion: [2, 3]
-        runner:
-        - name: Ubuntu x86
-          tags: [ubuntu-22.04] # GitHub-hosted
-        - name: Amazon Linux arm
-          tags: [self-hosted, linux, arm64]
-        exclude:
-          # fuse3 is not available on Amazon Linux 2
-          - runner:
-              name: Amazon Linux arm
-              tags: [self-hosted, linux, arm64]
-            fuseVersion: 3
-
-    steps:
-    - name: Configure AWS credentials
-      uses: aws-actions/configure-aws-credentials@v4
-      with:
-        role-to-assume: ${{ vars.ACTIONS_IAM_ROLE }}
-        aws-region: ${{ vars.S3_REGION }}
-    - name: Checkout code
-      uses: actions/checkout@v4
-      with:
-        ref: ${{ inputs.ref }}
-        submodules: true
-        persist-credentials: false
-    - name: Set up Rust toolchain
-      uses: actions-rust-lang/setup-rust-toolchain@v1
-      with:
-        # setup-rust-toolchain sets "-D warnings" by default, and Rust treats any warning as compile error.
-        # We need to this currently because `mountpoint-s3-fuser` contains some warnings and it breaks the build.
-        rustflags: ""
-    - name: Install operating system dependencies
-      uses: ./.github/actions/install-dependencies
-      with:
-        fuseVersion: ${{ matrix.fuseVersion }}
-    - name: Build tests
-      run: cargo test --features $RUST_FEATURES --no-run
-    - name: Run tests
-      run: cargo test --features $RUST_FEATURES
-    - name: Save dump files
-      if: ${{ failure() && matrix.runner.name == 'Amazon Linux arm' }}
-      run: ./.github/actions/scripts/save-coredump.sh
-
-  s3express-test:
-    name: S3 Express One Zone tests (${{ matrix.runner.name }}, FUSE ${{ matrix.fuseVersion }})
+    name: FS Tests (${{ matrix.bucket-type.name }}, ${{ matrix.runner.name }}, FUSE ${{ matrix.fuseVersion }})
     runs-on: ${{ matrix.runner.tags }}
 
     environment: ${{ inputs.environment }}
+    env:
+      features: fuse_tests,s3_tests,fips_tests,event_log,second_account_tests,manifest,${{ matrix.bucket-type.feature }}
+      packages: --package mountpoint-s3 --package mountpoint-s3-fs
 
     strategy:
       fail-fast: false
       matrix:
+        bucket-type:
+        - name: S3
+          feature: 
+        - name: S3XOZ
+          feature: s3express_tests
         fuseVersion: [2, 3]
         runner:
         - name: Ubuntu x86
           tags: [ubuntu-22.04] # GitHub-hosted
-        - name: Amazon Linux arm
+        - name: AL2 arm
           tags: [self-hosted, linux, arm64]
         exclude:
           # fuse3 is not available on Amazon Linux 2
           - runner:
-              name: Amazon Linux arm
+              name: AL2 arm
               tags: [self-hosted, linux, arm64]
             fuseVersion: 3
 
@@ -141,14 +96,13 @@ jobs:
       with:
         fuseVersion: ${{ matrix.fuseVersion }}
     - name: Build tests
-      run: cargo test --features '${{ env.RUST_FEATURES }},s3express_tests' --no-run
+      run: cargo test ${{ env.packages }} --features '${{ env.features }}' --no-run
     - name: Run tests
-      run: cargo test --features '${{ env.RUST_FEATURES }},s3express_tests'
+      run: cargo test ${{ env.packages }} --features '${{ env.features }}'
     - name: Save dump files
-      if: ${{ failure() && matrix.runner.name == 'Amazon Linux arm' }}
+      if: ${{ failure() && matrix.runner.name == 'AL2 arm' }}
       run: ./.github/actions/scripts/save-coredump.sh
 
-
   client-test:
     name: Client Tests (${{ matrix.bucket-type.name }}, ${{ matrix.runner.name }}, ${{ matrix.pool.name }})
     runs-on: ${{ matrix.runner.tags }}
@@ -164,14 +118,16 @@ jobs:
         bucket-type:
         - name: S3
           feature: 
-        - name: S3 Express One Zone
+        - name: S3XOZ
           feature: s3express_tests
         runner:
         - name: Ubuntu x86
           tags: [ubuntu-22.04] # GitHub-hosted
-        - name: Amazon Linux arm
+        - name: AL2 arm
           tags: [self-hosted, linux, arm64]
         pool:
+        - name: Default Pool
+          feature:
         - name: Test Pool
           feature: pool_tests
 
@@ -203,7 +159,7 @@ jobs:
     - name: Run tests
       run: cargo test ${{ env.packages }} --features '${{ env.features }}'
     - name: Save dump files
-      if: ${{ failure() && matrix.runner.name == 'Amazon Linux arm' }}
+      if: ${{ failure() && matrix.runner.name == 'AL2 arm' }}
       run: ./.github/actions/scripts/save-coredump.sh
 
   fstab:
@@ -219,7 +175,7 @@ jobs:
         runner:
           - name: Ubuntu x86
             tags: [ubuntu-22.04] # GitHub-hosted
-          - name: Amazon Linux arm
+          - name: AL2 arm
             tags: [self-hosted, linux, arm64]
 
     steps: