Link a job only with existing tracking issues

Assume that the referer has a issue_id otherwise do not link the URL in the
comments. Once a ticket has been created the referer should contain an ID
despite where it comes from.
It could go one step further to send a request and check the response but it
doesn't seem to be necessary.

https://progress.opensuse.org/issues/176826

Author: b10n1k

lib/OpenQA/Schema/ResultSet/Jobs.pm

@@ -485,8 +485,19 @@ sub mark_job_linked {
     return undef if !$job || ($referer->path_query =~ /^\/?$/);
     my $comments = $job->comments;
     return undef if $comments->search({text => {like => 'label:linked%'}}, {rows => 1})->first;
+    return undef unless _specific_issue_exists($referer);
     my $user = $self->result_source->schema->resultset('Users')->system({select => ['id']});
     $comments->create_with_event({text => "label:linked Job mentioned in $referer_url", user_id => $user->id});
 }
 
+sub _specific_issue_exists {
+    my ($referer_url) = @_;
+    my $url = Mojo::URL->new($referer_url);
+    my $path = $url->path();
+    my ($issue_id) = $path =~ m{\d+};
+    # Assume that the url is valid if there is issue_id
+    return 1 if defined $issue_id;
+    return 0;
+}
+
 1;

t/10-jobs-referal.t

@@ -32,7 +32,7 @@ sub job_is_linked ($job) {
 }
 
 subtest 'job is marked as linked if accessed from recognized referal' => sub {
-    my $test_referer = 'http://test.referer.info/foobar';
+    my $test_referer = 'http://test.referer.info/foobar/123';
     $t->app->config->{global}->{recognized_referers}
       = ['test.referer.info', 'test.referer1.info', 'test.referer2.info', 'test.referer3.info'];
     my %_settings = %settings;
@@ -61,6 +61,17 @@ subtest 'job is marked as linked if accessed from recognized referal' => sub {
       ->status_is(302);
     $linked = job_is_linked($job);
     is($linked, 1, 'job linked after accessed from known referer');
+
+
+    subtest 'do not link not existing tickets from recognized referal' => sub {
+        $test_referer = 'http://test.referer.info/foobar/new';
+        my $job = _job_create(\%_settings);
+        my $linked = job_is_linked($job);
+        is($linked, 0, 'new job is not linked');
+        $t->get_ok('/tests/' . $job->id => {Referer => $test_referer})->status_is(200);
+        $linked = job_is_linked($job);
+        is($linked, 0, 'job is not linked from known referer without an issue_id');
+    };
 };
 
 subtest 'job is not marked as linked if accessed from unrecognized referal' => sub {