Don't assert in Log::printf if file handle closed

benbuck · benbuck · commit 3cf8d800a884 · 2025-03-19T22:22:50.000-07:00
Fixes #17 - log.cpp line 166 filehandle_ != INVALID_HANDLE_VALUE
diff --git a/src/Log.cpp b/src/Log.cpp
@@ -162,8 +162,7 @@ void print(Level level, const char * str)
         return;
     }
 
-    if (enableLogging_) {
-        assert(fileHandle_ != INVALID_HANDLE_VALUE);
+    if (enableLogging_ && (fileHandle_ != INVALID_HANDLE_VALUE)) {
         DWORD bytesWritten = 0;
         WriteFile(fileHandle_, line.c_str(), (DWORD)line.size(), &bytesWritten, nullptr);
         assert(bytesWritten == line.size());

Original file line number	Diff line number	Diff line change
`@@ -162,8 +162,7 @@ void print(Level level, const char * str)`
`162`	`162`	`return;`
`163`	`163`	`}`
`164`	`164`
`165`		`- if (enableLogging_) {`
`166`		`- assert(fileHandle_ != INVALID_HANDLE_VALUE);`
	`165`	`+ if (enableLogging_ && (fileHandle_ != INVALID_HANDLE_VALUE)) {`
`167`	`166`	`DWORD bytesWritten = 0;`
`168`	`167`	`WriteFile(fileHandle_, line.c_str(), (DWORD)line.size(), &bytesWritten, nullptr);`
`169`	`168`	`assert(bytesWritten == line.size());`