Change writeable dir search order

First tries in appdata, then in executable dir.

Fixes #16 - Put log file under %appdata% or ability to specify path?

Author: benbuck

README.md

@@ -111,8 +111,8 @@ The available settings correspond to some of the above features. The settings ar
   minimized.
 - **Enable log file**:
   This toggles whether Finestray saves logging information to a file or not. If enabled, Finestray first tries to save
-  the log file in the same location as the Finestray application, and if that's not possible it saves to
-  `%LOCALAPPDATA%\\Finestray\\Finestray.log`.
+  the log file to `%LOCALAPPDATA%\\Finestray\\Finestray.log`, and if that's not possible it saves in the same location
+  as the Finestray application.
 - **Minimize placement**:
   This controls where to place minimized windows minimized using Finestray. The choices are:
   - **Tray**: the window will get an icon in the tray.
@@ -164,9 +164,9 @@ At the bottom of the Settings dialog are six buttons: Help, About, Reset, Exit,
 - **OK**:
   Closes the Settings window and saves settings.
 
-Settings are automatically stored in a file called "Finestray.json". Finestray first tries to save them in the same
-location as the Finestray application, and if that's not possible it saves them to
-`%LOCALAPPDATA%\\Finestray\\Finestray.json`.
+Settings are automatically stored in a file called "Finestray.json". Finestray first tries to save them to
+`%LOCALAPPDATA%\\Finestray\\Finestray.json`, and if that's not possible it saves them in the same location as the
+Finestray application.
 
 ### Modifiers and Hotkeys
 

src/Path.cpp

@@ -139,13 +139,6 @@ std::string getWriteableDir()
 
     std::string dir;
 
-    dir = getExecutableDir();
-    if (!dir.empty() && checkWriteableDir(dir)) {
-        DEBUG_PRINTF("using executable dir '%s' as writeable dir\n", dir.c_str());
-        writeableDir_ = dir;
-        return dir;
-    }
-
     dir = getAppDataDir();
     if (!dir.empty()) {
         dir = pathJoin(dir, APP_NAME);
@@ -166,6 +159,13 @@ std::string getWriteableDir()
         }
     }
 
+    dir = getExecutableDir();
+    if (!dir.empty() && checkWriteableDir(dir)) {
+        DEBUG_PRINTF("using executable dir '%s' as writeable dir\n", dir.c_str());
+        writeableDir_ = dir;
+        return dir;
+    }
+
     WARNING_PRINTF("no writeable dir found\n");
     return std::string();
 }