type-fixup! reverts win32 install removal

Author: ChrisC

shared/commands/install.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { install } = require('../install/macos');
+const { loadOsModule } = require('../helpers/load-os-module');
 
 module.exports = /** @type {import('yargs').CommandModule} */ ({
   command: 'install',
@@ -12,8 +12,10 @@ module.exports = /** @type {import('yargs').CommandModule} */ ({
     });
   },
   async handler({ unattended }) {
-    const installed = await install({ unattended });
-    const result = installed ? 'Installation completed successfully.' : 'Already installed';
-    console.log(result);
+    const installDelegate = loadOsModule('install', {
+      darwin: () => require('../install/macos'),
+      win32: () => require('../install/win32'),
+    });
+    await installDelegate.install({ unattended });
   },
 });

shared/install/macos.js

@@ -83,7 +83,7 @@ const promptForManualKeyPress = async () => {
  * @param {boolean} options.unattended - Whether installation should fail if
  *                                       human intervention is required
  *
- * @returns {Promise<boolean>}
+ * @returns {Promise<void>}
  */
 exports.install = async function ({ unattended }) {
   const options = await getExecOptions();
@@ -103,14 +103,14 @@ exports.install = async function ({ unattended }) {
   }
 
   if (await isInstalled()) {
-    return false;
+    console.log('Already installed.');
   }
 
   await removeQuarantine(options);
   await registerExtensions(options);
   await enableExtension();
   await setSystemVoice(VOICE_IDENTIFIER);
-  return true;
+  console.log('Installation completed successfully.');
 };
 
 /**

shared/install/win32.js

@@ -10,6 +10,7 @@ const MAKE_VOICE_EXE = 'MakeVoice.exe';
 
 exports.install = async function () {
   await exec(`${MAKE_VOICE_EXE}`, await getExecOptions());
+  console.log('Installation completed successfully.');
 };
 
 exports.uninstall = async function () {